Commit6ee0093

committed

improve error message for case when default range interval is NULL

1 parentba578fe commit6ee0093Copy full SHA for 6ee0093

File tree

-6

lines changed

-6

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ SELECT set_interval('test_interval.abc', NULL::INT2);`
`18`	`18`
`19`	`19`	`/* pg_pathman shouldn't be able to create a new partition */`
`20`	`20`	`INSERT INTO test_interval.abc VALUES (250);`
`21`		`-ERROR: cannotfind appropriate partition for key '250'`
	`21`	`+ERROR: cannotspawn new partition for key '250'`
`22`	`22`	`/* Set a trivial interval */`
`23`	`23`	`SELECT set_interval('test_interval.abc', 0);`
`24`	`24`	`ERROR: interval should not be trivial`
`@@ -61,7 +61,7 @@ SELECT set_interval('test_interval.abc', NULL::INT4);`
`61`	`61`
`62`	`62`	`/* pg_pathman shouldn't be able to create a new partition */`
`63`	`63`	`INSERT INTO test_interval.abc VALUES (250);`
`64`		`-ERROR: cannotfind appropriate partition for key '250'`
	`64`	`+ERROR: cannotspawn new partition for key '250'`
`65`	`65`	`/* Set a trivial interval */`
`66`	`66`	`SELECT set_interval('test_interval.abc', 0);`
`67`	`67`	`ERROR: interval should not be trivial`
`@@ -104,7 +104,7 @@ SELECT set_interval('test_interval.abc', NULL::INT8);`
`104`	`104`
`105`	`105`	`/* pg_pathman shouldn't be able to create a new partition */`
`106`	`106`	`INSERT INTO test_interval.abc VALUES (250);`
`107`		`-ERROR: cannotfind appropriate partition for key '250'`
	`107`	`+ERROR: cannotspawn new partition for key '250'`
`108`	`108`	`/* Set a trivial interval */`
`109`	`109`	`SELECT set_interval('test_interval.abc', 0);`
`110`	`110`	`ERROR: interval should not be trivial`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -408,9 +408,11 @@ create_partitions_for_value_internal(Oid relid, Datum value, Oid value_type,`
`408`	`408`	`/* Check if interval is set */`
`409`	`409`	`if (isnull[Anum_pathman_config_range_interval-1])`
`410`	`410`	`{`
`411`		`-elog(ERROR,`
`412`		`-"cannot find appropriate partition for key '%s'",`
`413`		`-datum_to_cstring(value,value_type));`
	`411`	`+ereport(ERROR,`
	`412`	`+(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
	`413`	`+errmsg("cannot spawn new partition for key '%s'",`
	`414`	`+datum_to_cstring(value,value_type)),`
	`415`	`+errdetail("default range interval is NULL")));`
`414`	`416`	`}`
`415`	`417`
`416`	`418`	`/* Retrieve interval as TEXT from tuple */`

Comments

(0)