NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit6dfc946

committed

Fix description of WAL record XLOG_BTREE_META_CLEANUP

This record uses one metadata buffer and registers some data associatedto the buffer, but when parsing the record for its description a directaccess to the record data was done, but there is none. This leadsusually to an incorrect description, but can also cause crashes like inpg_waldump. Instead, fix things so as the parsing uses the dataassociated to the metadata block.This is an oversight from3d92796, so backpatch down to 11.Author: Michael PaquierDescription:https://postgr.es/m/20190617013059.GA3153@paquier.xyzBackpatch-through: 11

1 parent5246d3e commit6dfc946Copy full SHA for 6dfc946

File tree

1 file changed

-1

lines changed

src/backend/access/rmgrdesc
- nbtdesc.c

1 file changed

-1

lines changed

`‎src/backend/access/rmgrdesc/nbtdesc.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,10 @@ btree_desc(StringInfo buf, XLogReaderState *record)`
`98`	`98`	`}`
`99`	`99`	`caseXLOG_BTREE_META_CLEANUP:`
`100`	`100`	`{`
`101`		`-xl_btree_metadataxlrec= (xl_btree_metadata)rec;`
	`101`	`+xl_btree_metadata*xlrec;`
`102`	`102`
	`103`	`+xlrec= (xl_btree_metadata*)XLogRecGetBlockData(record,0,`
	`104`	`+NULL);`
`103`	`105`	`appendStringInfo(buf,"oldest_btpo_xact %u; last_cleanup_num_heap_tuples: %f",`
`104`	`106`	`xlrec->oldest_btpo_xact,`
`105`	`107`	`xlrec->last_cleanup_num_heap_tuples);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6dfc946

File tree

1 file changed

1 file changed

`‎src/backend/access/rmgrdesc/nbtdesc.c`

0 commit comments