Commit6ce43ab

committed

add some comments and fixme's

1 parent64f29f3 commit6ce43abCopy full SHA for 6ce43ab

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2374,7 +2374,7 @@ static void MtmInitialize()`
`2374`	`2374`	`Mtm->nLiveNodes=0;//MtmNodes;`
`2375`	`2375`	`Mtm->nAllNodes=MtmNodes;`
`2376`	`2376`	`Mtm->disabledNodeMask=7;//XXXX`
`2377`		`-Mtm->clique=7;// XXXX`
	`2377`	`+Mtm->clique=7;// XXXX ! should be inverted !`
`2378`	`2378`	`Mtm->stalledNodeMask=0;`
`2379`	`2379`	`Mtm->stoppedNodeMask=0;`
`2380`	`2380`	`Mtm->deadNodeMask=0;`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -366,8 +366,7 @@ pglogical_receiver_main(Datum main_arg)`
`366`	`366`	`}`
`367`	`367`	`if (n_deleted_slots==Mtm->nAllNodes-1)`
`368`	`368`	`{`
`369`		`-elog(WARNING,"All neighbour nopes have no replication slot for us. Exiting.");`
`370`		`-kill(PostmasterPid,SIGTERM);`
	`369`	`+elog(FATAL,"All neighbour nopes have no replication slot for us. Exiting.");`
`371`	`370`	`}`
`372`	`371`	`proc_exit(1);`
`373`	`372`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ MtmCheckState(void)`
`143`	`143`
`144`	`144`
`145`	`145`	`void`
`146`		`-MtmStateProcessNeighborEvent(intnode_id,MtmNeighborEventev)`
	`146`	`+MtmStateProcessNeighborEvent(intnode_id,MtmNeighborEventev)// XXXX camelcase node_id`
`147`	`147`	`{`
`148`	`148`	`MTM_LOG1("[STATE] Node %i: %s",node_id,MtmNeighborEventMnem[ev]);`
`149`	`149`
`@@ -402,7 +402,7 @@ MtmRefreshClusterStatus()`
`402`	`402`
`403`	`403`	`if (newClique!=trivialClique)`
`404`	`404`	`{`
`405`		`-MTM_LOG1("[STATE] NONTRIVIAL CLIQUE!");`
	`405`	`+MTM_LOG1("[STATE] NONTRIVIAL CLIQUE! (trivial: %s)",maskToString(trivialClique,Mtm->nAllNodes));// XXXX some false-positives, fixme`
`406`	`406`	`}`
`407`	`407`
`408`	`408`	`/*`

Comments

(0)