Commit6c08905

committed

Remove overenthusiastic free'ing of comment dependencies; could lead to

core dump in pg_dump when dumping views having comments. See bug #855.

1 parent1868b0b commit6c08905Copy full SHA for 6c08905

File tree

-7

lines changed

-7

lines changed

Lines changed: 2 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`*by PostgreSQL`
`13`	`13`	`*`
`14`	`14`	`* IDENTIFICATION`
`15`		`- * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.312 2002/12/21 22:45:09 tgl Exp $`
	`15`	`+ * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.313 2002/12/27 17:10:45 tgl Exp $`
`16`	`16`	`*`
`17`	`17`	`*-------------------------------------------------------------------------`
`18`	`18`	`*/`
`@@ -5496,12 +5496,7 @@ dumpOneTable(Archive fout, TableInfo tbinfo, TableInfo *g_tblinfo)`
`5496`	`5496`	`/* Dump Table Comments */`
`5497`	`5497`	`dumpTableComment(fout,tbinfo,reltypename,commentDeps);`
`5498`	`5498`
`5499`		`-if (commentDeps)`
`5500`		`-{`
`5501`		`-for (j=0; (*commentDeps)[j]!=NULL;j++)`
`5502`		`-free((void) (commentDeps)[j]);`
`5503`		`-free(commentDeps);`
`5504`		`-}`
	`5499`	`+/* commentDeps now belongs to the archive entry ... don't free it! */`
`5505`	`5500`
`5506`	`5501`	`destroyPQExpBuffer(query);`
`5507`	`5502`	`destroyPQExpBuffer(q);`

Comments

(0)