NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit69e931f

committed

Fix access-off-end-of-array in clog.c.

Sloppy loop coding in set_status_by_pages() resulted in fetching one arrayelement more than it should from the subxids[] array. The odds of thisresulting in SIGSEGV are pretty small, but we've certainly seen that happenwith similar mistakes elsewhere. While at it, we can get rid of an extraTransactionIdToPage() calculation per loop.Per report from David Binderman. Back-patch to all supported branches,since this code is quite old.Discussion:https://postgr.es/m/HE1PR0802MB2331CBA919CBFFF0C465EB429C710@HE1PR0802MB2331.eurprd08.prod.outlook.com

1 parentd441cff commit69e931fCopy full SHA for 69e931f

File tree

1 file changed

-3

lines changed

src/backend/access/transam
- clog.c

1 file changed

-3

lines changed

`‎src/backend/access/transam/clog.c`

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -226,21 +226,27 @@ set_status_by_pages(int nsubxids, TransactionId *subxids,`
`226`	`226`	`intoffset=0;`
`227`	`227`	`inti=0;`
`228`	`228`
	`229`	`+Assert(nsubxids>0);/* else the pageno fetch above is unsafe */`
	`230`	`+`
`229`	`231`	`while (i<nsubxids)`
`230`	`232`	`{`
`231`	`233`	`intnum_on_page=0;`
	`234`	`+intnextpageno;`
`232`	`235`
`233`		`-while (TransactionIdToPage(subxids[i])==pageno&&i<nsubxids)`
	`236`	`+do`
`234`	`237`	`{`
	`238`	`+nextpageno=TransactionIdToPage(subxids[i]);`
	`239`	`+if (nextpageno!=pageno)`
	`240`	`+break;`
`235`	`241`	`num_on_page++;`
`236`	`242`	`i++;`
`237`		`-}`
	`243`	`+}while (i<nsubxids);`
`238`	`244`
`239`	`245`	`TransactionIdSetPageStatus(InvalidTransactionId,`
`240`	`246`	`num_on_page,subxids+offset,`
`241`	`247`	`status,lsn,pageno);`
`242`	`248`	`offset=i;`
`243`		`-pageno=TransactionIdToPage(subxids[offset]);`
	`249`	`+pageno=nextpageno;`
`244`	`250`	`}`
`245`	`251`	`}`
`246`	`252`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit69e931f

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/clog.c`

0 commit comments