NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit655393a

committed

Fix parallel hash join path search.

When the very cheapest path is not parallel-safe, we want to instead usethe cheapest unparameterized path that is. The old code searchedinnerrel->cheapest_parameterized_paths, but that isn't right, becausethe path we want may not be in that list. Search innerrel->pathlistinstead.Spotted by Dilip Kumar.Discussion:http://postgr.es/m/CAFiTN-szCEcZrQm0i_w4xqSaRUTOUFstNu32Zn4rxxDcoa8gnA@mail.gmail.com

1 parentb2678ef commit655393aCopy full SHA for 655393a

File tree

1 file changed

-4

lines changed

src/backend/optimizer/path
- joinpath.c

1 file changed

-4

lines changed

`‎src/backend/optimizer/path/joinpath.c`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1510,17 +1510,17 @@ hash_inner_and_outer(PlannerInfo *root,`
`1510`	`1510`	`/*`
`1511`	`1511`	`* Normally, given that the joinrel is parallel-safe, the cheapest`
`1512`	`1512`	`* total inner path will also be parallel-safe, but if not, we'll`
`1513`		`- * have to searchcheapest_parameterized_pathsfor the cheapest`
`1514`		`- *safe, unparameterized innerpath. If doing JOIN_UNIQUE_INNER,`
`1515`		`- *we can't use any alternativeinner path.`
	`1513`	`+ * have to search for the cheapest safe, unparameterized inner`
	`1514`	`+ * path. If doing JOIN_UNIQUE_INNER, we can't use any alternative`
	`1515`	`+ * inner path.`
`1516`	`1516`	`*/`
`1517`	`1517`	`if (cheapest_total_inner->parallel_safe)`
`1518`	`1518`	`cheapest_safe_inner=cheapest_total_inner;`
`1519`	`1519`	`elseif (save_jointype!=JOIN_UNIQUE_INNER)`
`1520`	`1520`	`{`
`1521`	`1521`	`ListCell*lc;`
`1522`	`1522`
`1523`		`-foreach(lc,innerrel->cheapest_parameterized_paths)`
	`1523`	`+foreach(lc,innerrel->pathlist)`
`1524`	`1524`	`{`
`1525`	`1525`	`Pathinnerpath= (Path)lfirst(lc);`
`1526`	`1526`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit655393a

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/joinpath.c`

0 commit comments