Commit60369db

committed

Fix calculation of how much shared memory is required to store a TOC.

Commitac883ac refactored shm_toc_estimate() but changed its calculationof shared memory size for TOC incorrectly. Previously this could cause toolarge memory to be allocated.Back-patch to v11 where the bug was introduced.Author: Takayuki TsunakawaDiscussion:https://postgr.es/m/TYAPR01MB2990BFB73170E2C4921E2C4DFEA80@TYAPR01MB2990.jpnprd01.prod.outlook.com

1 parent79d3ac7 commit60369dbCopy full SHA for 60369db

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -265,8 +265,8 @@ shm_toc_estimate(shm_toc_estimator *e)`
`265`	`265`	`Sizesz;`
`266`	`266`
`267`	`267`	`sz= offsetof(shm_toc,toc_entry);`
`268`		`-sz+=add_size(sz,mul_size(e->number_of_keys,sizeof(shm_toc_entry)));`
`269`		`-sz+=add_size(sz,e->space_for_chunks);`
	`268`	`+sz=add_size(sz,mul_size(e->number_of_keys,sizeof(shm_toc_entry)));`
	`269`	`+sz=add_size(sz,e->space_for_chunks);`
`270`	`270`
`271`	`271`	`returnBUFFERALIGN(sz);`
`272`	`272`	`}`

Comments

(0)