NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit5d923eb

committed

Use snprintf not sprintf in pg_waldump's timestamptz_to_str.

This could only cause an issue if strftime returned a ridiculouslylong timezone name, which seems unlikely; and it wouldn't qualifyas a security problem even then, since pg_waldump (nee pg_xlogdump)is a debug tool not part of the server. But gcc 8 has started issuingwarnings about it, so let's use snprintf and be safe.Backpatch to 9.3 where this code was added.Discussion:https://postgr.es/m/21789.1529170195@sss.pgh.pa.us

1 parent0dcf68e commit5d923ebCopy full SHA for 5d923eb

File tree

1 file changed

-1

lines changed

src/bin/pg_waldump
- compat.c

1 file changed

-1

lines changed

`‎src/bin/pg_waldump/compat.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,8 @@ timestamptz_to_str(TimestampTz dt)`
`58`	`58`	`strftime(ts,sizeof(ts),"%Y-%m-%d %H:%M:%S",ltime);`
`59`	`59`	`strftime(zone,sizeof(zone),"%Z",ltime);`
`60`	`60`
`61`		`-sprintf(buf,"%s.%06d %s",ts, (int) (dt %USECS_PER_SEC),zone);`
	`61`	`+snprintf(buf,sizeof(buf),"%s.%06d %s",`
	`62`	`+ts, (int) (dt %USECS_PER_SEC),zone);`
`62`	`63`
`63`	`64`	`returnbuf;`
`64`	`65`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5d923eb

File tree

1 file changed

1 file changed

`‎src/bin/pg_waldump/compat.c`

0 commit comments