Commit5d1af6a

committed

build_subquery_pathkeys() was examining wrong copy of subquery target list,

causing it to fail to recognize the output ordering of subqueries thatcontain set operations (UNION/INTERSECT/EXPECT). Per example from Karel Zak.

1 parentf1d0269 commit5d1af6aCopy full SHA for 5d1af6a

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`* Portions Copyright (c) 1994, Regents of the University of California`
`12`	`12`	`*`
`13`	`13`	`* IDENTIFICATION`
`14`		`- * $PostgreSQL: pgsql/src/backend/optimizer/path/pathkeys.c,v 1.55 2003/12/03 17:45:07 tgl Exp $`
	`14`	`+ * $PostgreSQL: pgsql/src/backend/optimizer/path/pathkeys.c,v 1.56 2004/04/07 17:42:28 tgl Exp $`
`15`	`15`	`*`
`16`	`16`	`*-------------------------------------------------------------------------`
`17`	`17`	`*/`
`@@ -757,6 +757,7 @@ build_subquery_pathkeys(Query root, RelOptInfo rel, Query *subquery)`
`757`	`757`	`List*retval=NIL;`
`758`	`758`	`intretvallen=0;`
`759`	`759`	`intouter_query_keys=length(root->query_pathkeys);`
	`760`	`+List*sub_tlist=rel->subplan->targetlist;`
`760`	`761`	`List*l;`
`761`	`762`
`762`	`763`	`foreach(l,subquery->query_pathkeys)`
`@@ -789,7 +790,7 @@ build_subquery_pathkeys(Query root, RelOptInfo rel, Query *subquery)`
`789`	`790`	`Node*sub_key=sub_item->key;`
`790`	`791`	`List*k;`
`791`	`792`
`792`		`-foreach(k,subquery->targetList)`
	`793`	`+foreach(k,sub_tlist)`
`793`	`794`	`{`
`794`	`795`	`TargetEntrytle= (TargetEntry)lfirst(k);`
`795`	`796`

Comments

(0)