Commit5be673a

committed

fix bug in 2pc decoding

1 parent3f3082c commit5be673aCopy full SHA for 5be673a

File tree

+12

-5

lines changed

+12

-5

lines changed

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,26 +45,32 @@ SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'inc`
`45`	`45`	`BEGIN`
`46`	`46`	`table public.test_prepared1: INSERT: id[integer]:1`
`47`	`47`	`COMMIT`
	`48`	`+ COMMIT`
`48`	`49`	`BEGIN`
`49`	`50`	`table public.test_prepared1: INSERT: id[integer]:2`
`50`	`51`	`COMMIT`
`51`	`52`	`BEGIN`
`52`		`- table public.test_prepared1: INSERT: id[integer]:4`
	`53`	`+ table public.test_prepared1: INSERT: id[integer]:3`
	`54`	`+ COMMIT`
`53`	`55`	`COMMIT`
`54`	`56`	`BEGIN`
`55`		`- table public.test_prepared2: INSERT: id[integer]:7`
	`57`	`+ table public.test_prepared1: INSERT: id[integer]:4`
`56`	`58`	`COMMIT`
`57`	`59`	`BEGIN`
`58`	`60`	`table public.test_prepared1: INSERT: id[integer]:5`
`59`	`61`	`table public.test_prepared1: INSERT: id[integer]:6 data[text]:'frakbar'`
`60`	`62`	`COMMIT`
`61`	`63`	`BEGIN`
	`64`	`+ table public.test_prepared2: INSERT: id[integer]:7`
	`65`	`+ COMMIT`
	`66`	`+ COMMIT`
	`67`	`+ BEGIN`
`62`	`68`	`table public.test_prepared1: INSERT: id[integer]:8 data[text]:null`
`63`	`69`	`COMMIT`
`64`	`70`	`BEGIN`
`65`	`71`	`table public.test_prepared2: INSERT: id[integer]:9`
`66`	`72`	`COMMIT`
`67`		`-(22 rows)`
	`73`	`+(28 rows)`
`68`	`74`
`69`	`75`	`SELECT pg_drop_replication_slot('regression_slot');`
`70`	`76`	`pg_drop_replication_slot`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -640,15 +640,16 @@ DecodeCommit(LogicalDecodingContext ctx, XLogRecordBuffer buf,`
`640`	`640`	`* empty. So we can skip use shortcut for coomiting bare xact.`
`641`	`641`	`*/`
`642`	`642`	`strcpy(ctx->reorder->gid,parsed->twophase_gid);`
	`643`	`+*ctx->reorder->state_3pc='\0';`
`643`	`644`	`ReorderBufferCommitBareXact(ctx->reorder,xid,buf->origptr,buf->endptr,`
`644`	`645`	`commit_time,origin_id,origin_lsn);`
`645`	`646`	`}else {`
	`647`	`+*ctx->reorder->gid='\0';`
	`648`	`+*ctx->reorder->state_3pc='\0';`
`646`	`649`	`/* replay actions of all transaction + subtransactions in order */`
`647`	`650`	`ReorderBufferCommit(ctx->reorder,xid,buf->origptr,buf->endptr,`
`648`	`651`	`commit_time,origin_id,origin_lsn);`
`649`		`-*ctx->reorder->gid='\0';`
`650`	`652`	`}`
`651`		`-*ctx->reorder->state_3pc='\0';`
`652`	`653`	`}`
`653`	`654`
`654`	`655`	`staticvoid`

Comments

(0)