Commit5baf869

committed

pg_dump: Remove query truncation in error messages

Remove the behavior that a query mentioned in an error message would betruncated to 128 characters. The queries that pg_dump runs are oftenlonger than that, and this behavior makes analyzing failures harderunnecessarily.Discussion:https://www.postgresql.org/message-id/flat/63201ef9-26fb-3f1f-664d-98531678cebc%402ndquadrant.com

1 parent4fdb8a8 commit5baf869Copy full SHA for 5baf869

File tree

-12

lines changed

-12

lines changed

Lines changed: 1 addition & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,6 @@`
`25`	`25`	`#endif`
`26`	`26`
`27`	`27`
`28`		`-#defineDB_MAX_ERR_STMT 128`
`29`		`-`
`30`	`28`	`/* translator: this is a module name */`
`31`	`29`	`staticconstchar*modulename=gettext_noop("archiver (db)");`
`32`	`30`
`@@ -449,7 +447,6 @@ ExecuteSqlCommand(ArchiveHandle AH, const char qry, const char *desc)`
`449`	`447`	`{`
`450`	`448`	`PGconn*conn=AH->connection;`
`451`	`449`	`PGresult*res;`
`452`		`-charerrStmt[DB_MAX_ERR_STMT];`
`453`	`450`
`454`	`451`	`#ifdefNOT_USED`
`455`	`452`	`fprintf(stderr,"Executing: '%s'\n\n",qry);`
`@@ -469,16 +466,8 @@ ExecuteSqlCommand(ArchiveHandle AH, const char qry, const char *desc)`
`469`	`466`	`break;`
`470`	`467`	`default:`
`471`	`468`	`/* trouble */`
`472`		`-strncpy(errStmt,qry,DB_MAX_ERR_STMT);/* strncpy required here */`
`473`		`-if (errStmt[DB_MAX_ERR_STMT-1]!='\0')`
`474`		`-{`
`475`		`-errStmt[DB_MAX_ERR_STMT-4]='.';`
`476`		`-errStmt[DB_MAX_ERR_STMT-3]='.';`
`477`		`-errStmt[DB_MAX_ERR_STMT-2]='.';`
`478`		`-errStmt[DB_MAX_ERR_STMT-1]='\0';`
`479`		`-}`
`480`	`469`	`warn_or_exit_horribly(AH,modulename,"%s: %s Command was: %s\n",`
`481`		`-desc,PQerrorMessage(conn),errStmt);`
	`470`	`+desc,PQerrorMessage(conn),qry);`
`482`	`471`	`break;`
`483`	`472`	`}`
`484`	`473`

Comments

(0)