- Notifications
You must be signed in to change notification settings - Fork28
Commit5bab198
committed
Fix bit-rot in pg_upgrade's test.sh, and improve documentation.
Doing a cross-version upgrade test with test.sh evidently hasn't beentested since circa 9.2, because the script lacked case branches forold-version servers newer than 9.1. Future-proof that a bit, andclean up breakage induced by our recent drop of V0 function callprotocol (namely that oldstyle_length() isn't in the regressionsuite anymore).(This isn't enough to make the test work perfectly cleanly acrossversions, but at least it finishes and provides dump files thatyou can diff manually. One issue I didn't touch is that we mightwant to execute the "reindex_hash.sql" file in the new DB beforedumping it, so that the hash indexes don't vanish from the dump.)Improve the TESTING doc file: put the tl;dr version at the top notthe bottom, and bring its explanation of how to run a cross-versiontest up to speed, since the installcheck target isn't there and won'tbe resurrected. Improve the comment in the Makefile about why not.In passing, teach .gitignore and "make clean" about a couple morejunk output files.Discussion:https://postgr.es/m/14058.1496892482@sss.pgh.pa.us1 parente3df8f8 commit5bab198
4 files changed
+53
-29
lines changedLines changed: 2 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
4 | 4 |
| |
5 | 5 |
| |
6 | 6 |
| |
| 7 | + | |
| 8 | + | |
7 | 9 |
| |
8 | 10 |
|
Lines changed: 3 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
32 | 32 |
| |
33 | 33 |
| |
34 | 34 |
| |
| 35 | + | |
35 | 36 |
| |
36 | 37 |
| |
37 | 38 |
| |
38 | 39 |
| |
39 | 40 |
| |
40 | 41 |
| |
41 |
| - | |
42 |
| - | |
43 |
| - | |
| 42 | + | |
| 43 | + |
Lines changed: 28 additions & 20 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
1 | 28 |
| |
2 | 29 |
| |
3 | 30 |
| |
| |||
7 | 34 |
| |
8 | 35 |
| |
9 | 36 |
| |
10 |
| - | |
| 37 | + | |
11 | 38 |
| |
12 | 39 |
| |
13 | 40 |
| |
| |||
60 | 87 |
| |
61 | 88 |
| |
62 | 89 |
| |
63 |
| - | |
64 |
| - | |
65 |
| - | |
66 |
| - | |
67 |
| - | |
68 |
| - | |
69 |
| - | |
70 |
| - | |
71 |
| - | |
72 |
| - | |
73 |
| - | |
74 |
| - | |
75 |
| - | |
76 |
| - | |
77 |
| - | |
78 |
| - | |
79 |
| - | |
80 |
| - | |
81 |
| - | |
|
Lines changed: 20 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
170 | 170 |
| |
171 | 171 |
| |
172 | 172 |
| |
173 |
| - | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
174 | 176 |
| |
175 |
| - | |
176 | 177 |
| |
177 | 178 |
| |
178 | 179 |
| |
179 |
| - | |
| 180 | + | |
180 | 181 |
| |
181 |
| - | |
182 |
| - | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
183 | 197 |
| |
184 |
| - | |
| 198 | + | |
185 | 199 |
| |
186 | 200 |
| |
187 | 201 |
| |
|
0 commit comments
Comments
(0)