Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit59f9cd9

Browse files
committed
Fix build failure on header generation with repetitive builds of MSVC
GenerateConfigHeader() in Solution.pm was complaining about unuseddefine symbols even if a newer config header was not generated, causingsuccessive build attempts with MSVC to fail.Oversight in commit8f4fb4c.Author: Kyotaro HoriguchiReviewed-by: Juan José Santamaría FlechaDiscussion:https://postgr.es/m/20200218.160500.44393633318853097.horikyota.ntt@gmail.com
1 parent3639071 commit59f9cd9

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

‎src/tools/msvc/Solution.pm

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -826,13 +826,14 @@ EOF
826826
subGenerateConfigHeader
827827
{
828828
my ($self,$config_header,$defines,$required) =@_;
829-
my%defines_copy =%$defines;
830829

831830
my$config_header_in =$config_header .'.in';
832831

833832
if (IsNewer($config_header,$config_header_in) ||
834833
IsNewer($config_header,__FILE__))
835834
{
835+
my%defines_copy =%$defines;
836+
836837
open(my$i,'<',$config_header_in)
837838
|| confess"Could not open$config_header_in\n";
838839
open(my$o,'>',$config_header)
@@ -871,10 +872,11 @@ sub GenerateConfigHeader
871872
}
872873
close($o);
873874
close($i);
874-
}
875-
if ($required &&scalar(keys%defines_copy) > 0)
876-
{
877-
croak"unused defines:" .join('',keys%defines_copy);
875+
876+
if ($required &&scalar(keys%defines_copy) > 0)
877+
{
878+
croak"unused defines:" .join('',keys%defines_copy);
879+
}
878880
}
879881
}
880882

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp