Commit594f617

committed

fix crash on RESET ALL (issue #121)

1 parentfc365c5 commit594f617Copy full SHA for 594f617

File tree

+48

-1

lines changed

+48

-1

lines changed

Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -855,6 +855,25 @@ NOTICE: drop cascades to 2 other objects`
`855`	`855`	`DROP SCHEMA calamity CASCADE;`
`856`	`856`	`NOTICE: drop cascades to 15 other objects`
`857`	`857`	`DROP EXTENSION pg_pathman;`
	`858`	`+/*`
	`859`	`+ * -------------------------------`
	`860`	`+ * Special tests (SET statement)`
	`861`	`+ * -------------------------------`
	`862`	`+ */`
	`863`	`+CREATE EXTENSION pg_pathman;`
	`864`	`+SET pg_pathman.enable = false;`
	`865`	`+NOTICE: RuntimeAppend, RuntimeMergeAppend and PartitionFilter nodes and some other options have been disabled`
	`866`	`+SET pg_pathman.enable = true;`
	`867`	`+NOTICE: RuntimeAppend, RuntimeMergeAppend and PartitionFilter nodes and some other options have been enabled`
	`868`	`+SET pg_pathman.enable = false;`
	`869`	`+NOTICE: RuntimeAppend, RuntimeMergeAppend and PartitionFilter nodes and some other options have been disabled`
	`870`	`+RESET pg_pathman.enable;`
	`871`	`+NOTICE: RuntimeAppend, RuntimeMergeAppend and PartitionFilter nodes and some other options have been enabled`
	`872`	`+RESET ALL;`
	`873`	`+BEGIN; ROLLBACK;`
	`874`	`+BEGIN ISOLATION LEVEL SERIALIZABLE; ROLLBACK;`
	`875`	`+BEGIN; SET TRANSACTION ISOLATION LEVEL SERIALIZABLE; ROLLBACK;`
	`876`	`+DROP EXTENSION pg_pathman;`
`858`	`877`	`/*`
`859`	`878`	`* -------------------------------------`
`860`	`879`	`* Special tests (pathman_cache_stats)`

Lines changed: 21 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -369,6 +369,27 @@ DROP EXTENSION pg_pathman;`
`369`	`369`
`370`	`370`
`371`	`371`
	`372`	`+/*`
	`373`	`+ * -------------------------------`
	`374`	`+ * Special tests (SET statement)`
	`375`	`+ * -------------------------------`
	`376`	`+*/`
	`377`	`+`
	`378`	`+CREATE EXTENSION pg_pathman;`
	`379`	`+`
	`380`	`+SETpg_pathman.enable= false;`
	`381`	`+SETpg_pathman.enable= true;`
	`382`	`+SETpg_pathman.enable= false;`
	`383`	`+RESETpg_pathman.enable;`
	`384`	`+RESET ALL;`
	`385`	`+BEGIN;ROLLBACK;`
	`386`	`+BEGIN ISOLATION LEVEL SERIALIZABLE;ROLLBACK;`
	`387`	`+BEGIN;SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;ROLLBACK;`
	`388`	`+`
	`389`	`+DROP EXTENSION pg_pathman;`
	`390`	`+`
	`391`	`+`
	`392`	`+`
`372`	`393`	`/*`
`373`	`394`	`* -------------------------------------`
`374`	`395`	`* Special tests (pathman_cache_stats)`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -125,8 +125,15 @@ xact_is_set_stmt(Node stmt, const char name)`
`125`	`125`	`if (!IsA(stmt,VariableSetStmt))`
`126`	`126`	`return false;`
`127`	`127`
`128`		`-if (!name\|\|pg_strcasecmp(name, ((VariableSetStmt*)stmt)->name)==0)`
	`128`	`+if (!name)`
`129`	`129`	`return true;`
	`130`	`+else`
	`131`	`+{`
	`132`	`+charset_name= ((VariableSetStmt)stmt)->name;`
	`133`	`+`
	`134`	`+if (set_name&&pg_strcasecmp(name,set_name)==0)`
	`135`	`+return true;`
	`136`	`+}`
`130`	`137`
`131`	`138`	`return false;`
`132`	`139`	`}`

Comments

(0)