- Notifications
You must be signed in to change notification settings - Fork28
Commit551cc9a
committed
Make PostgresNode::append_conf append a newline automatically.
Although the documentation for append_conf said clearly that it didn'tadd a newline, many test authors seem to have forgotten that ... or maybethey just consulted the example at the top of the POD documentation,which clearly shows adding a config entry without bothering to add atrailing newline. The worst part of that is that it works, as long asyou don't do it more than once, since the backend isn't picky aboutwhether config files end with newlines. So there's not a strong forcingfunction reminding test authors not to do it like that. Upshot is thatthis is a terribly fragile way to go about things, and there's at leastone existing test case that is demonstrably broken and not testing whatit thinks it is.Let's just make append_conf append a newline, instead; that is clearlyway safer than the old definition.I also cleaned up a few call sites that were unnecessarily ugly.(I left things alone in places where it's plausible that additionalconfig lines would need to be added someday.)Back-patch the change in append_conf itself to 9.6 where it was added,as having a definitional inconsistency between branches would obviouslybe pretty hazardous for back-patching TAP tests. The other changes arejust cosmetic and don't need to be back-patched.Discussion:https://postgr.es/m/19751.1492892376@sss.pgh.pa.us1 parent95a2316 commit551cc9a
1 file changed
+2
-2
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
444 | | - | |
| 444 | + | |
445 | 445 | | |
446 | 446 | | |
447 | 447 | | |
| |||
451 | 451 | | |
452 | 452 | | |
453 | 453 | | |
454 | | - | |
| 454 | + | |
455 | 455 | | |
456 | 456 | | |
457 | 457 | | |
| |||
0 commit comments
Comments
(0)