NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit51be673

committed

Fix some issues with TAP tests of pg_basebackup

ee9e145 has fixed the tests of pg_basebackup for checksums a first time,still one seek() call missed the shot. Also, the data written in filesto emulate corruptions was not actually writing zeros as the quotingstyle was incorrect.Author: Michael BanckDiscussion:https://postgr.es/m/1550153276.796.35.camel@credativ.deBackpatch-through: 11

1 parent1d93d18 commit51be673Copy full SHA for 51be673

File tree

1 file changed

-4

lines changed

src/bin/pg_basebackup/t
- 010_pg_basebackup.pl

1 file changed

-4

lines changed

`‎src/bin/pg_basebackup/t/010_pg_basebackup.pl‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,7 @@`
`502`	`502`	`system_or_bail'pg_ctl','-D',$pgdata,'stop';`
`503`	`503`	`open$file,'+<',"$pgdata/$file_corrupt1";`
`504`	`504`	`seek($file,$pageheader_size, 0);`
`505`		`-syswrite($file,'\0\0\0\0\0\0\0\0\0');`
	`505`	`+syswrite($file,"\0\0\0\0\0\0\0\0\0");`
`506`	`506`	`close$file;`
`507`	`507`	`system_or_bail'pg_ctl','-D',$pgdata,'start';`
`508`	`508`
`@@ -521,7 +521,7 @@`
`521`	`521`	`{`
`522`	`522`	`my$offset =$pageheader_size +$i *$block_size;`
`523`	`523`	`seek($file,$offset, 0);`
`524`		`-syswrite($file,'\0\0\0\0\0\0\0\0\0');`
	`524`	`+syswrite($file,"\0\0\0\0\0\0\0\0\0");`
`525`	`525`	`}`
`526`	`526`	`close$file;`
`527`	`527`	`system_or_bail'pg_ctl','-D',$pgdata,'start';`
`@@ -537,8 +537,8 @@`
`537`	`537`	`# induce corruption in a second file`
`538`	`538`	`system_or_bail'pg_ctl','-D',$pgdata,'stop';`
`539`	`539`	`open$file,'+<',"$pgdata/$file_corrupt2";`
`540`		`-seek($file,4000, 0);`
`541`		`-syswrite($file,'\0\0\0\0\0\0\0\0\0');`
	`540`	`+seek($file,$pageheader_size, 0);`
	`541`	`+syswrite($file,"\0\0\0\0\0\0\0\0\0");`
`542`	`542`	`close$file;`
`543`	`543`	`system_or_bail'pg_ctl','-D',$pgdata,'start';`
`544`	`544`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit51be673

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/t/010_pg_basebackup.pl‎`

0 commit comments