NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit514a731

committed

Simplify static function in extension.c

An extra argument for the filename defining the extension scriptlocation was present, aimed at being used for error reporting, but hasnever been used. This was around since extensions have been added ind9572c4.Author: Yugo NagataReviewed-by: Tatsuo IshiiDiscussion:https://postgr.es/m/20180907180504.1ff19e1675bb44a67e9c7ab1@sraoss.co.jp

1 parente5f1bb9 commit514a731Copy full SHA for 514a731

File tree

1 file changed

-4

lines changed

src/backend/commands
- extension.c

1 file changed

-4

lines changed

`‎src/backend/commands/extension.c`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -683,8 +683,6 @@ read_extension_script_file(const ExtensionControlFile *control,`
`683`	`683`	`/*`
`684`	`684`	`* Execute given SQL string.`
`685`	`685`	`*`
`686`		`- * filename is used only to report errors.`
`687`		`- *`
`688`	`686`	`* Note: it's tempting to just use SPI to execute the string, but that does`
`689`	`687`	`* not work very well. The really serious problem is that SPI will parse,`
`690`	`688`	`* analyze, and plan the whole string before executing any of it; of course`
`@@ -694,7 +692,7 @@ read_extension_script_file(const ExtensionControlFile *control,`
`694`	`692`	`* could be very long.`
`695`	`693`	`*/`
`696`	`694`	`staticvoid`
`697`		`-execute_sql_string(constcharsql,constcharfilename)`
	`695`	`+execute_sql_string(constchar*sql)`
`698`	`696`	`{`
`699`	`697`	`List*raw_parsetree_list;`
`700`	`698`	`DestReceiver*dest;`
`@@ -921,7 +919,7 @@ execute_extension_script(Oid extensionOid, ExtensionControlFile *control,`
`921`	`919`	`/* And now back to C string */`
`922`	`920`	`c_sql=text_to_cstring(DatumGetTextPP(t_sql));`
`923`	`921`
`924`		`-execute_sql_string(c_sql,filename);`
	`922`	`+execute_sql_string(c_sql);`
`925`	`923`	`}`
`926`	`924`	`PG_CATCH();`
`927`	`925`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit514a731

File tree

1 file changed

1 file changed

`‎src/backend/commands/extension.c`

0 commit comments