NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit513ff52

committed

Suppress compiler warnings when building with --enable-dtrace.

Most versions of "dtrace -h" drop const qualifiers from the declarationsof probe functions (though macOS gets it right). This causes compilerwarnings when we pass in pointers to const. Repair by extending ourexisting post-processing of the probes.h file. To do so, assume that all"char *" arguments should be "const char *"; that seems reasonably safe.Thomas MunroDiscussion:https://postgr.es/m/CAEepm=2j1pWSruQJqJ91ZDzD8w9ZZDsM4j2C6x75C-VryWg-_w@mail.gmail.com

1 parentf34f0e4 commit513ff52Copy full SHA for 513ff52

File tree

1 file changed

-1

lines changed

src/backend/utils
- Makefile

1 file changed

-1

lines changed

`‎src/backend/utils/Makefile`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -49,10 +49,15 @@ ifneq ($(enable_dtrace), yes)`
`49`	`49`	`probes.h: Gen_dummy_probes.sed`
`50`	`50`	`endif`
`51`	`51`
	`52`	`+# We editorialize on dtrace's output to the extent of changing the macro`
	`53`	`+# names (from POSTGRESQL_foo to TRACE_POSTGRESQL_foo) and changing any`
	`54`	`+# "char " arguments to "const char ".`
`52`	`55`	`probes.h: probes.d`
`53`	`56`	`ifeq ($(enable_dtrace), yes)`
`54`	`57`	`$(DTRACE) -C -h -s $< -o $@.tmp`
`55`		`-sed -e 's/POSTGRESQL_/TRACE_POSTGRESQL_/g' $@.tmp >$@`
	`58`	`+sed -e 's/POSTGRESQL_/TRACE_POSTGRESQL_/g' \`
	`59`	`+ -e 's/( char \/(const char */g' \`
	`60`	`+ -e 's/, char \/, const char */g' $@.tmp >$@`
`56`	`61`	`rm $@.tmp`
`57`	`62`	`else`
`58`	`63`	`sed -f $(srcdir)/Gen_dummy_probes.sed $< >$@`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit513ff52

File tree

1 file changed

1 file changed

`‎src/backend/utils/Makefile`

0 commit comments