NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commit5041cdf

committed

Partially revert commit536d47b.

Per buildfarm, the "#ifdef F_SETFD" removed in that commit actuallyis needed on Windows, because fcntl() isn't available at all on thatplatform, unless using Cygwin. We could perhaps spell it more like"#ifdef HAVE_FCNTL", or "#ifndef WIN32", but it's not clear thatthose choices are better.It does seem that we don't need the bogus manual definition ofFD_CLOEXEC, though, so keep that change.Discussion:https://postgr.es/m/26254.1492805635@sss.pgh.pa.us

1 parentf58b664 commit5041cdfCopy full SHA for 5041cdf

File tree

1 file changed

-0

lines changed

src/interfaces/libpq
- fe-connect.c

1 file changed

-0

lines changed

`‎src/interfaces/libpq/fe-connect.c‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1983,6 +1983,7 @@ PQconnectPoll(PGconn *conn)`
`1983`	`1983`	`continue;`
`1984`	`1984`	`}`
`1985`	`1985`
	`1986`	`+#ifdefF_SETFD`
`1986`	`1987`	`if (fcntl(conn->sock,F_SETFD,FD_CLOEXEC)==-1)`
`1987`	`1988`	`{`
`1988`	`1989`	`appendPQExpBuffer(&conn->errorMessage,`
`@@ -1992,6 +1993,7 @@ PQconnectPoll(PGconn *conn)`
`1992`	`1993`	`conn->addr_cur=addr_cur->ai_next;`
`1993`	`1994`	`continue;`
`1994`	`1995`	`}`
	`1996`	`+#endif/* F_SETFD */`
`1995`	`1997`
`1996`	`1998`	`if (!IS_AF_UNIX(addr_cur->ai_family))`
`1997`	`1999`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5041cdf

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-connect.c‎`

0 commit comments