NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commit50363c8

committed

Validate number of steps specified in permutation

A permutation that specifies more steps than defined causesisolationtester to crash, so avoid that. Using less steps than definedshould probably not be a problem, but no spec currently does that.

1 parent1b9dea0 commit50363c8Copy full SHA for 50363c8

File tree

1 file changed

-1

lines changed

src/test/isolation
- isolationtester.c

1 file changed

-1

lines changed

`‎src/test/isolation/isolationtester.c‎`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -395,6 +395,12 @@ run_named_permutations(TestSpec * testspec)`
`395`	`395`	`Permutation*p=testspec->permutations[i];`
`396`	`396`	`Step**steps;`
`397`	`397`
	`398`	`+if (p->nsteps!=nallsteps)`
	`399`	`+{`
	`400`	`+fprintf(stderr,"invalid number of steps in permutation %d\n",i+1);`
	`401`	`+exit_nicely();`
	`402`	`+}`
	`403`	`+`
`398`	`404`	`steps=malloc(p->nstepssizeof(Step));`
`399`	`405`
`400`	`406`	`/* Find all the named steps from the lookup table */`
`@@ -404,7 +410,8 @@ run_named_permutations(TestSpec * testspec)`
`404`	`410`	`sizeof(Step*),&step_bsearch_cmp));`
`405`	`411`	`if (steps[j]==NULL)`
`406`	`412`	`{`
`407`		`-fprintf(stderr,"undefined step \"%s\" specified in permutation\n",p->stepnames[j]);`
	`413`	`+fprintf(stderr,"undefined step \"%s\" specified in permutation\n",`
	`414`	`+p->stepnames[j]);`
`408`	`415`	`exit_nicely();`
`409`	`416`	`}`
`410`	`417`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit50363c8

File tree

1 file changed

1 file changed

`‎src/test/isolation/isolationtester.c‎`

0 commit comments