NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit5035d7b

committed

pg_atoi() does range check on int4 data only if

"HAS_LONG_LONG" is defined based on the assumption thatstrtol() would return ERANGE if a platform does not support64-bit integers. In current PostgreSQL 6.5 (and 6.4.2)distribution, "HAS_LONG_LONG" is defined only if platformis "alpha". (See include/port/alpha.h) I think the int4range check should apply to linux_alpha as well. (I havenot tested yet but I guess this might be applicable tonewer Linux/i386 distributions which includes new GCC whichimplements long int as 64-bit int.)

1 parenta6c688d commit5035d7bCopy full SHA for 5035d7b

File tree

1 file changed

-3

lines changed

src/backend/utils/adt
- numutils.c

1 file changed

-3

lines changed

`‎src/backend/utils/adt/numutils.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`*`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/numutils.c,v 1.30 1999/05/25 16:12:14 momjian Exp $`
	`13`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/numutils.c,v 1.31 1999/07/08 00:27:01 momjian Exp $`
`14`	`14`	`*`
`15`	`15`	`*-------------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -76,7 +76,7 @@ pg_atoi(char *s, int size, int c)`
`76`	`76`	`switch (size)`
`77`	`77`	`{`
`78`	`78`	`casesizeof(int32):`
`79`		`-#ifdefHAS_LONG_LONG`
	`79`	`+#if defined(HAVE_LONG_INT_64)\|\| defined(HAVE_LONG_LONG_INT_64)`
`80`	`80`	`/* won't get ERANGE on these with 64-bit longs... */`
`81`	`81`	`if (l<INT_MIN)`
`82`	`82`	`{`
`@@ -88,7 +88,7 @@ pg_atoi(char *s, int size, int c)`
`88`	`88`	`errno=ERANGE;`
`89`	`89`	`elog(ERROR,"pg_atoi: error reading \"%s\": %m",s);`
`90`	`90`	`}`
`91`		`-#endif/HAS_LONG_LONG /`
	`91`	`+#endif/HAVE_LONG_INT_64 or HAVE_LONG_LONG_INT_64 /`
`92`	`92`	`break;`
`93`	`93`	`casesizeof(int16):`
`94`	`94`	`if (l<SHRT_MIN)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5035d7b

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/numutils.c`

0 commit comments