NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit501f583

committed

Fix cross-version compatibility checks of pg_verify_checksums

pg_verify_checksums performs a read of the control file, and the data itfetches should be from a data folder compatible with the major versionof Postgres the binary has been compiled with, but we never actuallychecked that compatibility.Reported-by: Sergei KornilovAuthor: Michael PaquierReviewed-by: Sergei KornilovDiscussion:https://postgr.es/m/155231347133.16480.11453587097036807558.pgcf@coridan.postgresql.orgBackpatch-through: 11

1 parentfd1eaf9 commit501f583Copy full SHA for 501f583

File tree

1 file changed

-0

lines changed

src/bin/pg_verify_checksums
- pg_verify_checksums.c

1 file changed

-0

lines changed

`‎src/bin/pg_verify_checksums/pg_verify_checksums.c`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -316,6 +316,13 @@ main(int argc, char *argv[])`
`316`	`316`	`exit(1);`
`317`	`317`	`}`
`318`	`318`
	`319`	`+if (ControlFile->pg_control_version!=PG_CONTROL_VERSION)`
	`320`	`+{`
	`321`	`+fprintf(stderr,_("%s: cluster is not compatible with this version of pg_verify_checksums\n"),`
	`322`	`+progname);`
	`323`	`+exit(1);`
	`324`	`+}`
	`325`	`+`
`319`	`326`	`if (ControlFile->state!=DB_SHUTDOWNED&&`
`320`	`327`	`ControlFile->state!=DB_SHUTDOWNED_IN_RECOVERY)`
`321`	`328`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit501f583

File tree

1 file changed

1 file changed

`‎src/bin/pg_verify_checksums/pg_verify_checksums.c`

0 commit comments