- Notifications
You must be signed in to change notification settings - Fork28
Commit4eca190
committed
Fix CREATE VIEW to allow zero-column views.
We should logically have allowed this case when we allowed zero-columntables, but it was overlooked.Although this might be thought a feature addition, it's really a bugfix, because it was possible to create a zero-column view viathe convert-table-to-view code path, and then you'd have a situationwhere dump/reload would fail. Hence, back-patch to all supportedbranches.Arrange the added test cases to provide coverage of the relatedpg_dump code paths (since these views will be dumped and reloadedduring the pg_upgrade regression test). I also made them testthe case where pg_dump has to postpone the view rule into post-data,which disturbingly had no regression coverage before.Report and patch by Ashutosh Sharma (test case by me)Discussion:https://postgr.es/m/CAE9k0PkmHdeSaeZt2ujnb_cKucmK3sDDceDzw7+d5UZoNJPYOg@mail.gmail.com1 parentd43a1ff commit4eca190
File tree
5 files changed
+31
-5
lines changed- src
- backend/commands
- test/regress
- expected
- sql
5 files changed
+31
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | 114 | | |
120 | 115 | | |
121 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
23 | 33 | | |
24 | 34 | | |
25 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1289 | 1289 | | |
1290 | 1290 | | |
1291 | 1291 | | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
1292 | 1300 | | |
1293 | 1301 | | |
1294 | 1302 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
| 208 | + | |
208 | 209 | | |
209 | 210 | | |
210 | 211 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
27 | 39 | | |
28 | 40 | | |
29 | 41 | | |
| |||
0 commit comments
Comments
(0)