NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commit4e20511

committed

Fix estimate_expression_value to constant-fold SQLValueFunction nodes.

Oversight in my commit0bb51aa. Noted while poking at a recentbug report --- HEAD's estimates for a query using CURRENT_DATEwere unexpectedly much worse than 9.6's.

1 parenteb68141 commit4e20511Copy full SHA for 4e20511

File tree

1 file changed

+17

-0

lines changed

src/backend/optimizer/util
- clauses.c

1 file changed

+17

-0

lines changed

`‎src/backend/optimizer/util/clauses.c‎`

Lines changed: 17 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3346,6 +3346,23 @@ eval_const_expressions_mutator(Node *node,`
`3346`	`3346`	`newcoalesce->location=coalesceexpr->location;`
`3347`	`3347`	`return (Node*)newcoalesce;`
`3348`	`3348`	`}`
	`3349`	`+caseT_SQLValueFunction:`
	`3350`	`+{`
	`3351`	`+/*`
	`3352`	`+ * All variants of SQLValueFunction are stable, so if we are`
	`3353`	`+ * estimating the expression's value, we should evaluate the`
	`3354`	`+ * current function value. Otherwise just copy.`
	`3355`	`+ */`
	`3356`	`+SQLValueFunctionsvf= (SQLValueFunction)node;`
	`3357`	`+`
	`3358`	`+if (context->estimate)`
	`3359`	`+return (Node)evaluate_expr((Expr)svf,`
	`3360`	`+svf->type,`
	`3361`	`+svf->typmod,`
	`3362`	`+InvalidOid);`
	`3363`	`+else`
	`3364`	`+returncopyObject((Node*)svf);`
	`3365`	`+}`
`3349`	`3366`	`caseT_FieldSelect:`
`3350`	`3367`	`{`
`3351`	`3368`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4e20511

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/util/clauses.c‎`

0 commit comments