Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit4d85c29

Browse files
committed
Improve comments in vacuum_rel() and analyze_rel().
Remove obsolete references to get_rel_oids(). Avoid listing specificrelkinds in the comments, since we seem unable to keep such thingsin sync with the code, and it's not all that helpful anyhow.Noted by Michael Paquier, though I rewrote the comments a bit more.Discussion:https://postgr.es/m/CAB7nPqTWiN9zwKTaOrsnKiGDChqRt7C1+CiiDk4N4OMn92rs6A@mail.gmail.com
1 parent4b2ba1f commit4d85c29

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

‎src/backend/commands/analyze.c‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -207,9 +207,7 @@ analyze_rel(Oid relid, RangeVar *relation, int options,
207207
}
208208

209209
/*
210-
* Check that it's a plain table, materialized view, or foreign table; we
211-
* used to do this in get_rel_oids() but seems safer to check after we've
212-
* locked the relation.
210+
* Check that it's of an analyzable relkind, and set up appropriately.
213211
*/
214212
if (onerel->rd_rel->relkind==RELKIND_RELATION||
215213
onerel->rd_rel->relkind==RELKIND_MATVIEW)

‎src/backend/commands/vacuum.c‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1309,6 +1309,9 @@ vac_truncate_clog(TransactionId frozenXID,
13091309
*do not use it once we've successfully opened the rel, since it might
13101310
*be stale.
13111311
*
1312+
*Returns true if it's okay to proceed with a requested ANALYZE
1313+
*operation on this table.
1314+
*
13121315
*Doing one heap at a time incurs extra overhead, since we need to
13131316
*check that the heap exists again just before we vacuum it. The
13141317
*reason that we do this is so that vacuuming can be spread across
@@ -1444,9 +1447,7 @@ vacuum_rel(Oid relid, RangeVar *relation, int options, VacuumParams *params)
14441447
}
14451448

14461449
/*
1447-
* Check that it's a vacuumable relation; we used to do this in
1448-
* get_rel_oids() but seems safer to check after we've locked the
1449-
* relation.
1450+
* Check that it's of a vacuumable relkind.
14501451
*/
14511452
if (onerel->rd_rel->relkind!=RELKIND_RELATION&&
14521453
onerel->rd_rel->relkind!=RELKIND_MATVIEW&&
@@ -1478,17 +1479,16 @@ vacuum_rel(Oid relid, RangeVar *relation, int options, VacuumParams *params)
14781479
}
14791480

14801481
/*
1481-
*Ignorepartitioned tables as there is no work to be done.Since we
1482-
*release the lock here, it's possible that any partitions added from
1483-
*this point on will not get processed, but that seems harmless.
1482+
*Silently ignorepartitioned tables as there is no work to be done.The
1483+
*useful work is on their child partitions, which have been queued up for
1484+
*us separately.
14841485
*/
14851486
if (onerel->rd_rel->relkind==RELKIND_PARTITIONED_TABLE)
14861487
{
14871488
relation_close(onerel,lmode);
14881489
PopActiveSnapshot();
14891490
CommitTransactionCommand();
1490-
1491-
/* It's OK for other commands to look at this table */
1491+
/* It's OK to proceed with ANALYZE on this table */
14921492
return true;
14931493
}
14941494

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp