NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit4d53a2f

committed

Revert addition of "o" to tar options. This was intended to fix bug #4883,

but the cure appears to be worse than the disease. It turns out that GNUtar versions 1.14.x misinterpret -o as --same-owner, not --no-same-owner,leading to exactly the wrong behavior for both root and nonroot users.While that bug has been fixed for nearly five years, these tar versionsare still found in the wild, notably in OS X 10.4. Given that #4883 wasthe first complaint we'd heard, it's definitely not worth fixing at therisk of breaking things for other users. Perhaps revisit at a later datewhen we're not up against a release deadline.

1 parent41f467f commit4d53a2fCopy full SHA for 4d53a2f

File tree

1 file changed

-3

lines changed

doc
- Makefile

1 file changed

-3

lines changed

`‎doc/Makefile`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`#`
`5`	`5`	`# Copyright (c) 1994, Regents of the University of California`
`6`	`6`	`#`
`7`		`-# $PostgreSQL: pgsql/doc/Makefile,v 1.36 2009/06/2606:40:57 petere Exp $`
	`7`	`+# $PostgreSQL: pgsql/doc/Makefile,v 1.37 2009/06/27 21:06:46 tgl Exp $`
`8`	`8`	`#`
`9`	`9`	`#----------------------------------------------------------------------------`
`10`	`10`
`@@ -53,7 +53,7 @@ man1/.timestamp: man7/.timestamp`
`53`	`53`	`@echo timestamp>$@`
`54`	`54`
`55`	`55`	`man7/.timestamp: man.tar.gz`
`56`		`-gzip -d -c$<\|$(TAR)xof -`
	`56`	`+gzip -d -c$<\|$(TAR)xf -`
`57`	`57`	`ifneq ($(sqlmansectnum),7)`
`58`	`58`	`for file in man1/*.1; do \`
`59`	`59`	`mv $$file $$file.bak && \`
`@@ -76,7 +76,7 @@ endif # found_man`
`76`	`76`
`77`	`77`	`install: all installdirs`
`78`	`78`	`ifdeffound_html`
`79`		`-gzip -d -c $(srcdir)/postgres.tar.gz \| ( cd $(DESTDIR)$(htmldir)/html && $(TAR)xof - )`
	`79`	`+gzip -d -c $(srcdir)/postgres.tar.gz \| ( cd $(DESTDIR)$(htmldir)/html && $(TAR)xf - )`
`80`	`80`	`endif`
`81`	`81`	`ifdeffound_man`
`82`	`82`	`for file in man1/.1 man$(sqlmansectnum)/.$(sqlmansect) ; do \`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4d53a2f

File tree

1 file changed

1 file changed

`‎doc/Makefile`

0 commit comments