NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit4d41b2e

committed

Add QueryEnvironment to ExplainOneQuery_hook's parameter list.

This should have been done in commit18ce3a4, which added that parameterto ExplainOneQuery, but it was overlooked. This makes it impossible fora user of the hook to pass the queryEnv down to ExplainOnePlan.It's too late to change this API in v10, I suppose, but fortunatelypassing NULL to ExplainOnePlan will work in nearly all interestingcases in v10. That might not be true forever, so we'd better fix it.Tatsuro Yamada, reviewed by Thomas MunroDiscussion:https://postgr.es/m/890e8dd9-c1c7-a422-6892-874f5eaee048@lab.ntt.co.jp

1 parent9ff4f75 commit4d41b2eCopy full SHA for 4d41b2e

File tree

2 files changed

-2

lines changed

src
- backend/commands
  - explain.c
- include/commands
  - explain.h

2 files changed

-2

lines changed

`‎src/backend/commands/explain.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -351,7 +351,7 @@ ExplainOneQuery(Query *query, int cursorOptions,`
`351`	`351`	`/* if an advisor plugin is present, let it manage things */`
`352`	`352`	`if (ExplainOneQuery_hook)`
`353`	`353`	`(*ExplainOneQuery_hook) (query,cursorOptions,into,es,`
`354`		`-queryString,params);`
	`354`	`+queryString,params,queryEnv);`
`355`	`355`	`else`
`356`	`356`	`{`
`357`	`357`	`PlannedStmt*plan;`

`‎src/include/commands/explain.h`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ typedef void (ExplainOneQuery_hook_type) (Query query,`
`53`	`53`	`IntoClause*into,`
`54`	`54`	`ExplainState*es,`
`55`	`55`	`constchar*queryString,`
`56`		`-ParamListInfoparams);`
	`56`	`+ParamListInfoparams,`
	`57`	`+QueryEnvironment*queryEnv);`
`57`	`58`	`externPGDLLIMPORTExplainOneQuery_hook_typeExplainOneQuery_hook;`
`58`	`59`
`59`	`60`	`/* Hook for plugins to get control in explain_get_index_name() */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4d41b2e

File tree

2 files changed

2 files changed

`‎src/backend/commands/explain.c`

`‎src/include/commands/explain.h`

0 commit comments