Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit4c9e1bd

Browse files
committed
Reset memory context once per tuple in validateForeignKeyConstraint.
When using tableam ExecFetchSlotHeapTuple() might return a separatelyallocated tuple. We could use the shouldFree argument to explicitlyfree it, but it seems more robust to to protectAlso add a CHECK_FOR_INTERRUPTS() after each tuple. It's likely thateach AM has (heap does) a CFI somewhere in the relevant path, but itseems more robust to have one in validateForeignKeyConstraint()itself.Note that this only affects the cases that couldn't be optimized to beverified with a query.Author: Andres FreundReviewed-By: Tom Lane (in an earlier version)Discussion:https://postgr.es/m/19030.1554574075@sss.pgh.pa.ushttps://postgr.es/m/CAKJS1f_SHKcPYMsi39An5aUjhAcEMZb6Cx1Sj1QWEWSiKJkBVQ@mail.gmail.comhttps://postgr.es/m/20180711185628.mrvl46bjgk2uxoki@alap3.anarazel.de
1 parent41f5e04 commit4c9e1bd

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

‎src/backend/commands/tablecmds.c

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9593,6 +9593,8 @@ validateForeignKeyConstraint(char *conname,
95939593
TableScanDesc scan;
95949594
Triggertrig;
95959595
Snapshotsnapshot;
9596+
MemoryContext oldcxt;
9597+
MemoryContext perTupCxt;
95969598

95979599
ereport(DEBUG1,
95989600
(errmsg("validating foreign key constraint \"%s\"", conname)));
@@ -9628,11 +9630,18 @@ validateForeignKeyConstraint(char *conname,
96289630
slot = table_slot_create(rel, NULL);
96299631
scan = table_beginscan(rel, snapshot, 0, NULL);
96309632

9633+
perTupCxt = AllocSetContextCreate(CurrentMemoryContext,
9634+
"validateForeignKeyConstraint",
9635+
ALLOCSET_SMALL_SIZES);
9636+
oldcxt = MemoryContextSwitchTo(perTupCxt);
9637+
96319638
while (table_scan_getnextslot(scan, ForwardScanDirection, slot))
96329639
{
96339640
LOCAL_FCINFO(fcinfo, 0);
96349641
TriggerData trigdata;
96359642

9643+
CHECK_FOR_INTERRUPTS();
9644+
96369645
/*
96379646
* Make a call to the trigger function
96389647
*
@@ -9649,13 +9658,18 @@ validateForeignKeyConstraint(char *conname,
96499658
trigdata.tg_trigtuple = ExecFetchSlotHeapTuple(slot, false, NULL);
96509659
trigdata.tg_trigslot = slot;
96519660
trigdata.tg_newtuple = NULL;
9661+
trigdata.tg_newslot = NULL;
96529662
trigdata.tg_trigger = &trig;
96539663

96549664
fcinfo->context = (Node *) &trigdata;
96559665

96569666
RI_FKey_check_ins(fcinfo);
9667+
9668+
MemoryContextReset(perTupCxt);
96579669
}
96589670

9671+
MemoryContextSwitchTo(oldcxt);
9672+
MemoryContextDelete(perTupCxt);
96599673
table_endscan(scan);
96609674
UnregisterSnapshot(snapshot);
96619675
ExecDropSingleTupleTableSlot(slot);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp