Commit448fee2

committed

Make comments reflect that omission of SPI_gettypmod() is intentional.

1 parente852c5d commit448fee2Copy full SHA for 448fee2

File tree

-3

lines changed

-3

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -940,6 +940,12 @@ SPI_gettype(TupleDesc tupdesc, int fnumber)`
`940`	`940`	`returnresult;`
`941`	`941`	`}`
`942`	`942`
	`943`	`+/*`
	`944`	`+ * Get the data type OID for a column.`
	`945`	`+ *`
	`946`	`+ * There's nothing similar for typmod and typcollation. The rare consumers`
	`947`	`+ * thereof should inspect the TupleDesc directly.`
	`948`	`+ */`
`943`	`949`	`Oid`
`944`	`950`	`SPI_gettypeid(TupleDesctupdesc,intfnumber)`
`945`	`951`	`{`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -4446,7 +4446,6 @@ exec_eval_datum(PLpgSQL_execstate *estate,`
`4446`	`4446`	`errmsg("record \"%s\" has no field \"%s\"",`
`4447`	`4447`	`rec->refname,recfield->fieldname)));`
`4448`	`4448`	`*typeid=SPI_gettypeid(rec->tupdesc,fno);`
`4449`		`-/* XXX there's no SPI_gettypmod, for some reason */`
`4450`	`4449`	`if (fno>0)`
`4451`	`4450`	`*typetypmod=rec->tupdesc->attrs[fno-1]->atttypmod;`
`4452`	`4451`	`else`
`@@ -4623,12 +4622,10 @@ exec_get_datum_type_info(PLpgSQL_execstate *estate,`
`4623`	`4622`	`errmsg("record \"%s\" has no field \"%s\"",`
`4624`	`4623`	`rec->refname,recfield->fieldname)));`
`4625`	`4624`	`*typeid=SPI_gettypeid(rec->tupdesc,fno);`
`4626`		`-/* XXX there's no SPI_gettypmod, for some reason */`
`4627`	`4625`	`if (fno>0)`
`4628`	`4626`	`*typmod=rec->tupdesc->attrs[fno-1]->atttypmod;`
`4629`	`4627`	`else`
`4630`	`4628`	`*typmod=-1;`
`4631`		`-/* XXX there's no SPI_getcollation either */`
`4632`	`4629`	`if (fno>0)`
`4633`	`4630`	`*collation=rec->tupdesc->attrs[fno-1]->attcollation;`
`4634`	`4631`	`else/* no system column types have collation */`

Comments

(0)