Commit434146d

committed

pgbench: If we fail to send a command to the server, fail.

This beats the old behavior of busy-waiting hands down.Oversight in commit12788ae.Report by Pavan Deolasee. Patch by Fabien Coelho. Reviewed byPavan Deolasee.Discussion:http://postgr.es/m/CABOikdPhfXTypckMC1Ux6Ko+hKBWwUBA=EXsvamXYSg8M9J94w@mail.gmail.com

1 parent5cc5987 commit434146dCopy full SHA for 434146d

File tree

-6

lines changed

-6

lines changed

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -2157,12 +2157,8 @@ doCustom(TState thread, CState st, StatsData *agg)`
`2157`	`2157`	`{`
`2158`	`2158`	`if (!sendCommand(st,command))`
`2159`	`2159`	`{`
`2160`		`-/*`
`2161`		`- * Failed. Stay in CSTATE_START_COMMAND state, to`
`2162`		`- * retry. ??? What the point or retrying? Should`
`2163`		`- * rather abort?`
`2164`		`- */`
`2165`		`-return;`
	`2160`	`+commandFailed(st,"SQL command send failed");`
	`2161`	`+st->state=CSTATE_ABORTED;`
`2166`	`2162`	`}`
`2167`	`2163`	`else`
`2168`	`2164`	`st->state=CSTATE_WAIT_RESULT;`

Comments

(0)