Commit415b925

Neil Conway

committed

Fix a memory leak in psql: we'd leak a few PGresult handles if

a connectivity error occurred while executing one of the queriesfor "\d <table>". Not serious, but still worth fixing. Patch fromBrendan Jurd.

1 parent8964b41 commit415b925Copy full SHA for 415b925

File tree

-1

lines changed

-1

lines changed

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Copyright (c) 2000-2006, PostgreSQL Global Development Group`
`5`	`5`	`*`
`6`		`- * $PostgreSQL: pgsql/src/bin/psql/describe.c,v 1.147 2006/10/09 23:30:33 tgl Exp $`
	`6`	`+ * $PostgreSQL: pgsql/src/bin/psql/describe.c,v 1.148 2006/11/08 01:22:55 neilc Exp $`
`7`	`7`	`*/`
`8`	`8`	`#include"postgres_fe.h"`
`9`	`9`	`#include"describe.h"`
`@@ -1171,7 +1171,14 @@ describeOneTableDetails(const char *schemaname,`
`1171`	`1171`
`1172`	`1172`	`result6=PSQLexec(buf.data, false);`
`1173`	`1173`	`if (!result6)`
	`1174`	`+{`
	`1175`	`+PQclear(result1);`
	`1176`	`+PQclear(result2);`
	`1177`	`+PQclear(result3);`
	`1178`	`+PQclear(result4);`
	`1179`	`+PQclear(result5);`
`1174`	`1180`	`gotoerror_return;`
	`1181`	`+}`
`1175`	`1182`	`else`
`1176`	`1183`	`inherits_count=PQntuples(result6);`
`1177`	`1184`

Comments

(0)