Commit3f3d60d

committed

Fix race condition in ConditionVariablePrepareToSleep.

Thomas Munro

1 parentfc8219d commit3f3d60dCopy full SHA for 3f3d60d

File tree

-3

lines changed

-3

lines changed

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -71,14 +71,17 @@ ConditionVariablePrepareToSleep(ConditionVariable *cv)`
`71`	`71`	`&MyProc->procLatch,NULL);`
`72`	`72`	`}`
`73`	`73`
	`74`	`+/*`
	`75`	`+ * Reset my latch before adding myself to the queue and before entering`
	`76`	`+ * the caller's predicate loop.`
	`77`	`+ */`
	`78`	`+ResetLatch(&MyProc->procLatch);`
	`79`	`+`
`74`	`80`	`/* Add myself to the wait queue. */`
`75`	`81`	`SpinLockAcquire(&cv->mutex);`
`76`	`82`	`if (!proclist_contains(&cv->wakeup,pgprocno,cvWaitLink))`
`77`	`83`	`proclist_push_tail(&cv->wakeup,pgprocno,cvWaitLink);`
`78`	`84`	`SpinLockRelease(&cv->mutex);`
`79`		`-`
`80`		`-/* Reset my latch before entering the caller's predicate loop. */`
`81`		`-ResetLatch(&MyProc->procLatch);`
`82`	`85`	`}`
`83`	`86`
`84`	`87`	`/*--------------------------------------------------------------------------`

Comments

(0)