Commit3bdca3d

committed

Insert new item in the end of the page if it is the biggest item

1 parenta1da826 commit3bdca3dCopy full SHA for 3bdca3d

File tree

-6

lines changed

-6

lines changed

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -409,7 +409,7 @@ rumMergeItemPointers(RumState * rumstate, AttrNumber attno, RumKey * dst,`
`409`	`409`
`410`	`410`	`/*`
`411`	`411`	`* Checks, should we move to right link...`
`412`		`- * Compares insertingitemp pointer with right bound of current page`
	`412`	`+ * Compares insertingitem pointer with right bound of current page`
`413`	`413`	`*/`
`414`	`414`	`staticbool`
`415`	`415`	`dataIsMoveRight(RumBtreebtree,Pagepage)`
`@@ -909,7 +909,9 @@ dataPlaceToPage(RumBtree btree, Page page, OffsetNumber off)`
`909`	`909`	`if (stopAppend)`
`910`	`910`	`/* there is no free space on page */`
`911`	`911`	`break;`
`912`		`-elseif (RumPageRightMost(page))`
	`912`	`+elseif (RumPageRightMost(page)\|\|`
	`913`	`+/* Insert item in the end of the page */`
	`914`	`+off>maxoff)`
`913`	`915`	`/* force insertion of new item */`
`914`	`916`	`cmp=1;`
`915`	`917`	`elseif ((cmp=compareRumKey(btree->rumstate,btree->entryAttnum,`
`@@ -1211,7 +1213,7 @@ dataSplitPageInternal(RumBtree btree, Buffer lbuf, Buffer rbuf,`
`1211`	`1213`	`OffsetNumberseparator;`
`1212`	`1214`	`RumKey*bound;`
`1213`	`1215`	`PagenewlPage=PageGetTempPageCopy(BufferGetPage(lbuf));`
`1214`		`-RumKeyoldbound=*RumDataPageGetRightBound(newlPage);`
	`1216`	`+RumKeyoldbound=*RumDataPageGetRightBound(newlPage);`
`1215`	`1217`	`intsizeofitem=sizeof(PostingItem);`
`1216`	`1218`	`OffsetNumbermaxoff=RumPageGetOpaque(newlPage)->maxoff;`
`1217`	`1219`	`SizepageSize=PageGetPageSize(newlPage);`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -99,9 +99,9 @@ createPostingTree(RumState * rumstate, OffsetNumber attnum, Relation index,`
`99`	`99`	`* are making a leaf-level key entry containing a posting list of nipd items.`
`100`	`100`	`* If the caller is actually trying to make a posting-tree entry, non-leaf`
`101`	`101`	`* entry, or pending-list entry, it should pass nipd = 0 and then overwrite`
`102`		`- * the t_tid fields as necessary. In any case,ipd can be NULL to skip`
	`102`	`+ * the t_tid fields as necessary. In any case,items can be NULL to skip`
`103`	`103`	`* copying any itempointers into the posting list; the caller is responsible`
`104`		`- * for filling the posting list afterwards, ifipd = NULL and nipd > 0.`
	`104`	`+ * for filling the posting list afterwards, ifitems = NULL and nipd > 0.`
`105`	`105`	`*/`
`106`	`106`	`staticIndexTuple`
`107`	`107`	`RumFormTuple(RumState*rumstate,`
`@@ -348,7 +348,6 @@ buildFreshLeafTuple(RumState * rumstate,`
`348`	`348`	`if (size >=RumDataPageSize)`
`349`	`349`	`itemsCount--;`
`350`	`350`
`351`		`-`
`352`	`351`	`/*`
`353`	`352`	`* Build posting-tree-only result tuple. We do this first so as to`
`354`	`353`	`* fail quickly if the key is too big.`

Comments

(0)