NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit3a7bd59

committed

Re-allow SRFs and window functions within sub-selects within aggregates.

check_agg_arguments_walker threw an error upon seeing a SRF or windowfunction, but that is too aggressive: if the function is within asub-select then it's perfectly fine. I broke the SRF case in commit0436f6b by copying the logic for window functions ... but that wasbroken too, and had been since commiteaccfde.Repair both cases in HEAD, and the window function case back to 9.3.9.2 gets this right.

1 parentdf31a9f commit3a7bd59Copy full SHA for 3a7bd59

File tree

1 file changed

-1

lines changed

src/backend/parser
- parse_agg.c

1 file changed

-1

lines changed

`‎src/backend/parser/parse_agg.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -700,7 +700,7 @@ check_agg_arguments_walker(Node *node,`
`700`	`700`	`/* Continue and descend into subtree */`
`701`	`701`	`}`
`702`	`702`	`/* We can throw error on sight for a window function */`
`703`		`-if (IsA(node,WindowFunc))`
	`703`	`+if (IsA(node,WindowFunc)&&context->sublevels_up==0)`
`704`	`704`	`ereport(ERROR,`
`705`	`705`	`(errcode(ERRCODE_GROUPING_ERROR),`
`706`	`706`	`errmsg("aggregate function calls cannot contain window function calls"),`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3a7bd59

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_agg.c`

0 commit comments