NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit3a5e0a9

committed

Fix the new ARMv8 CRC code for short and unaligned input.

The code before the main loop, to handle the possible 1-7 unaligned bytesat the beginning of the input, was broken, and read past the input, if thethe input was very short.

1 parentee9e145 commit3a5e0a9Copy full SHA for 3a5e0a9

File tree

1 file changed

-3

lines changed

src/port
- pg_crc32c_armv8.c

1 file changed

-3

lines changed

`‎src/port/pg_crc32c_armv8.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,17 +29,17 @@ pg_comp_crc32c_armv8(pg_crc32c crc, const void *data, size_t len)`
`29`	`29`	`* significantly faster. Process leading bytes so that the loop below`
`30`	`30`	`* starts with a pointer aligned to eight bytes.`
`31`	`31`	`*/`
`32`		`-if (!PointerIsAligned(p,uint16)&&p<pend)`
	`32`	`+if (!PointerIsAligned(p,uint16)&&p+1 <=pend)`
`33`	`33`	`{`
`34`	`34`	`crc=__crc32cb(crc,*p);`
`35`	`35`	`p+=1;`
`36`	`36`	`}`
`37`		`-if (!PointerIsAligned(p,uint32)&&p<pend)`
	`37`	`+if (!PointerIsAligned(p,uint32)&&p+2 <=pend)`
`38`	`38`	`{`
`39`	`39`	`crc=__crc32ch(crc,(uint16)p);`
`40`	`40`	`p+=2;`
`41`	`41`	`}`
`42`		`-if (!PointerIsAligned(p,uint64)&&p<pend)`
	`42`	`+if (!PointerIsAligned(p,uint64)&&p+4 <=pend)`
`43`	`43`	`{`
`44`	`44`	`crc=__crc32cw(crc,(uint32)p);`
`45`	`45`	`p+=4;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3a5e0a9

File tree

1 file changed

1 file changed

`‎src/port/pg_crc32c_armv8.c`

0 commit comments