Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit3888b53

Browse files
committed
Fix duplicating ROOT page in concurrent updates.
1 parent00fbb64 commit3888b53

File tree

2 files changed

+41
-16
lines changed

2 files changed

+41
-16
lines changed

‎src/backend/access/nbtree/nbtinsert.c

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*
88
*
99
* IDENTIFICATION
10-
* $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.37 1999/04/12 16:56:08 vadim Exp $
10+
* $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.38 1999/04/22 08:19:59 vadim Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -398,6 +398,7 @@ _bt_insertonpg(Relation rel,
398398
OffsetNumbermaxoff;
399399
boolshifted= false;
400400
boolleft_chained= (lpageop->btpo_flags&BTP_CHAIN) ? true : false;
401+
boolis_root=lpageop->btpo_flags&BTP_ROOT;
401402

402403
/*
403404
* If we have to split leaf page in the chain of duplicates by new
@@ -570,9 +571,20 @@ _bt_insertonpg(Relation rel,
570571
* reasoning).
571572
*/
572573

574+
l_spl:;
573575
if (stack== (BTStack)NULL)
574576
{
575-
577+
if (!is_root)/* if this page was not root page */
578+
{
579+
elog(DEBUG,"btree: concurrent ROOT page split");
580+
stack= (BTStack)palloc(sizeof(BTStackData));
581+
stack->bts_blkno=lpageop->btpo_parent;
582+
stack->bts_offset=InvalidOffsetNumber;
583+
stack->bts_btitem= (BTItem)palloc(sizeof(BTItemData));
584+
/* bts_btitem will be initialized below */
585+
stack->bts_parent=NULL;
586+
gotol_spl;
587+
}
576588
/* create a new root node and release the split buffers */
577589
_bt_newroot(rel,buf,rbuf);
578590
_bt_relbuf(rel,buf,BT_WRITE);

‎src/backend/access/nbtree/nbtpage.c

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtpage.c,v 1.19 1999/03/28 20:31:57 vadim Exp $
11+
* $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtpage.c,v 1.20 1999/04/22 08:19:59 vadim Exp $
1212
*
1313
*NOTES
1414
* Postgres btree pages look like ordinary relation pages.The opaque
@@ -494,24 +494,37 @@ _bt_getstackbuf(Relation rel, BTStack stack, int access)
494494
opaque= (BTPageOpaque)PageGetSpecialPointer(page);
495495
maxoff=PageGetMaxOffsetNumber(page);
496496

497-
if (maxoff >=stack->bts_offset)
497+
if (stack->bts_offset==InvalidOffsetNumber||
498+
maxoff >=stack->bts_offset)
498499
{
499-
itemid=PageGetItemId(page,stack->bts_offset);
500-
item= (BTItem)PageGetItem(page,itemid);
501-
502-
/* if the item is where we left it, we're done */
503-
if (BTItemSame(item,stack->bts_btitem))
500+
/*
501+
* _bt_insertonpg set bts_offset to InvalidOffsetNumber
502+
* in the case of concurrent ROOT page split
503+
*/
504+
if (stack->bts_offset==InvalidOffsetNumber)
504505
{
505-
pfree(stack->bts_btitem);
506-
item_nbytes=ItemIdGetLength(itemid);
507-
item_save= (BTItem)palloc(item_nbytes);
508-
memmove((char*)item_save, (char*)item,item_nbytes);
509-
stack->bts_btitem=item_save;
510-
returnbuf;
506+
i=P_RIGHTMOST(opaque) ?P_HIKEY :P_FIRSTKEY;
507+
}
508+
else
509+
{
510+
itemid=PageGetItemId(page,stack->bts_offset);
511+
item= (BTItem)PageGetItem(page,itemid);
512+
513+
/* if the item is where we left it, we're done */
514+
if (BTItemSame(item,stack->bts_btitem))
515+
{
516+
pfree(stack->bts_btitem);
517+
item_nbytes=ItemIdGetLength(itemid);
518+
item_save= (BTItem)palloc(item_nbytes);
519+
memmove((char*)item_save, (char*)item,item_nbytes);
520+
stack->bts_btitem=item_save;
521+
returnbuf;
522+
}
523+
i=OffsetNumberNext(stack->bts_offset);
511524
}
512525

513526
/* if the item has just moved right on this page, we're done */
514-
for (i=OffsetNumberNext(stack->bts_offset);
527+
for (;
515528
i <=maxoff;
516529
i=OffsetNumberNext(i))
517530
{

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp