NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit3727afa

committed

Fix pg_type.typlen for newly-revived line type.

Commit261c7d4 removed the "m" fieldfrom struct LINE, but neglected to make pg_type.h's idea of the type'ssize match. This resulted in reading past the end of palloc'd LINEvalues when inserting them into tuples etc. In principle that couldcause a SIGSEGV, though the odds of detectable problems seem low.Bump catversion since this makes an incompatible on-disk format change.Note that if the line type had been in use in the field, this wouldbreak pg_upgrade'ability of databases containing line values; butit seems unlikely that there are any (they'd have had to be compiledwith -DENABLE_LINE_TYPE).Spotted by Andres Freund.

1 parentb2f7bd7 commit3727afaCopy full SHA for 3727afa

File tree

2 files changed

-2

lines changed

src/include/catalog
- catversion.h
- pg_type.h

2 files changed

-2

lines changed

`‎src/include/catalog/catversion.h`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,6 @@`
`53`	`53`	`*/`
`54`	`54`
`55`	`55`	`/yyyymmddN /`
`56`		`-#defineCATALOG_VERSION_NO201404241`
	`56`	`+#defineCATALOG_VERSION_NO201405051`
`57`	`57`
`58`	`58`	`#endif`

`‎src/include/catalog/pg_type.h`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -392,7 +392,7 @@ DATA(insert OID = 604 ( polygon PGNSP PGUID -1 f b G f t \054 0 0 1027 poly_`
`392`	`392`	`DESCR("geometric polygon '(pt1,...)'");`
`393`	`393`	`#definePOLYGONOID604`
`394`	`394`
`395`		`-DATA(insertOID=628 (linePGNSPPGUID32fbGft \0540701629line_inline_outline_recvline_send---dpf0-100_null__null__null_ ));`
	`395`	`+DATA(insertOID=628 (linePGNSPPGUID24fbGft \0540701629line_inline_outline_recvline_send---dpf0-100_null__null__null_ ));`
`396`	`396`	`DESCR("geometric line");`
`397`	`397`	`#defineLINEOID628`
`398`	`398`	`DATA(insertOID=629 (_linePGNSPPGUID-1fbAft \05406280array_inarray_outarray_recvarray_send--array_typanalyzedxf0-100_null__null__null_ ));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3727afa

File tree

2 files changed

2 files changed

`‎src/include/catalog/catversion.h`

`‎src/include/catalog/pg_type.h`

0 commit comments