Commit35438e5

committed

Minor code beautification in partition_bounds_equal.

Use get_greatest_modulus more consistently, instead of doing thesame thing in an ad-hoc manner in this one place.Ashutosh BapatDiscussion:http://postgr.es/m/CAFjFpReT9L4RCiJBKOyWC2=i02kv9uG2fx=4Fv7kFY2t0SPCgw@mail.gmail.com

1 parent9502227 commit35438e5Copy full SHA for 35438e5

File tree

-6

lines changed

-6

lines changed

Lines changed: 3 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -751,15 +751,13 @@ partition_bounds_equal(int partnatts, int16 parttyplen, bool parttypbyval,`
`751`	`751`
`752`	`752`	`if (b1->strategy==PARTITION_STRATEGY_HASH)`
`753`	`753`	`{`
`754`		`-intgreatest_modulus;`
	`754`	`+intgreatest_modulus=get_greatest_modulus(b1);`
`755`	`755`
`756`	`756`	`/*`
`757`	`757`	`* If two hash partitioned tables have different greatest moduli,`
`758`		`- * their partition schemes don't match. For hash partitioned table,`
`759`		`- * the greatest modulus is given by the last datum and number of`
`760`		`- * partitions is given by ndatums.`
	`758`	`+ * their partition schemes don't match.`
`761`	`759`	`*/`
`762`		`-if (b1->datums[b1->ndatums-1][0]!=b2->datums[b2->ndatums-1][0])`
	`760`	`+if (greatest_modulus!=get_greatest_modulus(b2))`
`763`	`761`	`return false;`
`764`	`762`
`765`	`763`	`/*`
`@@ -773,7 +771,6 @@ partition_bounds_equal(int partnatts, int16 parttyplen, bool parttypbyval,`
`773`	`771`	`* their indexes array will be same. So, it suffices to compare`
`774`	`772`	`* indexes array.`
`775`	`773`	`*/`
`776`		`-greatest_modulus=get_greatest_modulus(b1);`
`777`	`774`	`for (i=0;i<greatest_modulus;i++)`
`778`	`775`	`if (b1->indexes[i]!=b2->indexes[i])`
`779`	`776`	`return false;`

Comments

(0)