- Notifications
You must be signed in to change notification settings - Fork28
Commit35361ee
committed
Restrict vertical tightness to parentheses in Perl code
The vertical tightness settings collapse vertical whitespace betweenopening and closing brackets (parentheses, square brakets and braces).This can make data structures in particular harder to read, and is notvery consistent with our style in non-Perl code. This patch restrictsthat setting to parentheses only, and reformats all the perl codeaccordingly. Not applying this to parentheses has some unfortunateeffects, so the consensus is to keep the setting for parentheses and notfor the others.The diff for this patch does highlight some places where structuresshould have trailing commas. They can be added manually, as there is noautomatic tool to do so.Discussion:https://postgr.es/m/a2f2b87c-56be-c070-bfc0-36288b4b41c1@2ndQuadrant.com1 parent286bb24 commit35361ee
File tree
46 files changed
+1815
-851
lines changed- src
- backend
- catalog
- utils
- mb/Unicode
- bin
- pg_archivecleanup/t
- pg_basebackup/t
- pg_controldata/t
- pg_ctl/t
- pg_dump/t
- pg_resetwal/t
- pg_rewind
- t
- pgbench/t
- psql
- test
- kerberos/t
- modules/test_pg_dump/t
- perl
- recovery/t
- ssl
- tools
- msvc
- pgindent
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
46 files changed
+1815
-851
lines changedLines changed: 4 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
95 | 95 |
| |
96 | 96 |
| |
97 | 97 |
| |
98 |
| - | |
| 98 | + | |
| 99 | + | |
99 | 100 |
| |
100 | 101 |
| |
101 |
| - | |
| 102 | + | |
| 103 | + | |
102 | 104 |
| |
103 | 105 |
| |
104 | 106 |
| |
|
Lines changed: 4 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
97 | 97 |
| |
98 | 98 |
| |
99 | 99 |
| |
100 |
| - | |
| 100 | + | |
| 101 | + | |
101 | 102 |
| |
102 | 103 |
| |
103 | 104 |
| |
104 |
| - | |
| 105 | + | |
| 106 | + | |
105 | 107 |
| |
106 | 108 |
| |
107 | 109 |
| |
|
Lines changed: 4 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
48 | 48 |
| |
49 | 49 |
| |
50 | 50 |
| |
51 |
| - | |
| 51 | + | |
| 52 | + | |
52 | 53 |
| |
53 | 54 |
| |
54 | 55 |
| |
55 | 56 |
| |
56 |
| - | |
| 57 | + | |
| 58 | + | |
57 | 59 |
| |
58 | 60 |
| |
59 | 61 |
| |
|
Lines changed: 4 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
70 | 70 |
| |
71 | 71 |
| |
72 | 72 |
| |
73 |
| - | |
| 73 | + | |
| 74 | + | |
74 | 75 |
| |
75 | 76 |
| |
76 | 77 |
| |
77 |
| - | |
| 78 | + | |
| 79 | + | |
78 | 80 |
| |
79 | 81 |
| |
80 | 82 |
| |
|
Lines changed: 8 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
33 | 33 |
| |
34 | 34 |
| |
35 | 35 |
| |
36 |
| - | |
| 36 | + | |
| 37 | + | |
37 | 38 |
| |
38 | 39 |
| |
39 | 40 |
| |
40 | 41 |
| |
41 | 42 |
| |
42 |
| - | |
| 43 | + | |
| 44 | + | |
43 | 45 |
| |
44 | 46 |
| |
45 | 47 |
| |
| |||
52 | 54 |
| |
53 | 55 |
| |
54 | 56 |
| |
55 |
| - | |
| 57 | + | |
| 58 | + | |
56 | 59 |
| |
57 | 60 |
| |
58 | 61 |
| |
59 | 62 |
| |
60 |
| - | |
| 63 | + | |
| 64 | + | |
61 | 65 |
| |
62 | 66 |
| |
63 | 67 |
| |
|
0 commit comments
Comments
(0)