NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commit34f3b39

committed

Check for stack overflow in transformSetOperationTree().

Since transformSetOperationTree() recurses, it can be driven to stackoverflow with enough UNION/INTERSECT/EXCEPT clauses in a query. Add acheck to ensure it fails cleanly instead of crashing. Per report fromMatthew Gerber (though it's not clear whether this is the only thinggoing wrong for him).Historical note: I think the reasoning behind not putting a check here inthe beginning was that the check in transformExpr() ought to be sufficientto guard the whole parser. However, because transformSetOperationTree()recurses all the way to the bottom of the set-operation tree before doingany analysis of the statement's expressions, that check doesn't save it.

1 parentfa12cb7 commit34f3b39Copy full SHA for 34f3b39

File tree

1 file changed

-0

lines changed

src/backend/parser
- analyze.c

1 file changed

-0

lines changed

`‎src/backend/parser/analyze.c‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@`
`26`	`26`
`27`	`27`	`#include"access/sysattr.h"`
`28`	`28`	`#include"catalog/pg_type.h"`
	`29`	`+#include"miscadmin.h"`
`29`	`30`	`#include"nodes/makefuncs.h"`
`30`	`31`	`#include"nodes/nodeFuncs.h"`
`31`	`32`	`#include"optimizer/var.h"`
`@@ -1487,6 +1488,9 @@ transformSetOperationTree(ParseState pstate, SelectStmt stmt,`
`1487`	`1488`
`1488`	`1489`	`Assert(stmt&&IsA(stmt,SelectStmt));`
`1489`	`1490`
	`1491`	`+/* Guard against stack overflow due to overly complex set-expressions */`
	`1492`	`+check_stack_depth();`
	`1493`	`+`
`1490`	`1494`	`/*`
`1491`	`1495`	`* Validity-check both leaf and internal SELECTs for disallowed ops.`
`1492`	`1496`	`*/`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit34f3b39

File tree

1 file changed

1 file changed

`‎src/backend/parser/analyze.c‎`

0 commit comments