Commit336a578

committed

Fix incorrect assertion about historical snapshots.

Also fix some nearby comments.Andres Freund

1 parent890194f commit336a578Copy full SHA for 336a578

File tree

-4

lines changed

-4

lines changed

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -261,9 +261,11 @@ Snapshot`
`261`	`261`	`GetCatalogSnapshot(Oidrelid)`
`262`	`262`	`{`
`263`	`263`	`/*`
`264`		`- * Return historic snapshot if we're doing logical decoding, but`
`265`		`- * return a non-historic, snapshot if we temporarily are doing up2date`
`266`		`- * lookups.`
	`264`	`+ * Return historic snapshot while we're doing logical decoding, so we can`
	`265`	`+ * see the appropriate state of the catalog.`
	`266`	`+ *`
	`267`	`+ * This is the primary reason for needing to reset the system caches after`
	`268`	`+ * finishing decoding.`
`267`	`269`	`*/`
`268`	`270`	`if (HistoricSnapshotActive())`
`269`	`271`	`returnHistoricSnapshot;`
`@@ -352,7 +354,7 @@ SetTransactionSnapshot(Snapshot sourcesnap, TransactionId sourcexid)`
`352`	`354`
`353`	`355`	`Assert(RegisteredSnapshots==0);`
`354`	`356`	`Assert(FirstXactSnapshot==NULL);`
`355`		`-Assert(HistoricSnapshotActive());`
	`357`	`+Assert(!HistoricSnapshotActive());`
`356`	`358`
`357`	`359`	`/*`
`358`	`360`	`* Even though we are not going to use the snapshot it computes, we must`

Comments

(0)