NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit2ed391f

committed

Fix pgbench options -C and -R together

The bug is that prior to --rate doCustom was always disconnect/reconnectwithout exiting, but with rate it returns if it has to wait. However threadRuntest whether there is a connection before recalling doCustom, so it was nevercalled.Bug is not existed in head branch because of refactoring at12788ae, patch only 9.6Author: Fabien CoelhoReviewed-by: mehttps://commitfest.postgresql.org/13/970/

1 parent8de6278 commit2ed391fCopy full SHA for 2ed391f

File tree

1 file changed

-1

lines changed

src/bin/pgbench
- pgbench.c

1 file changed

-1

lines changed

`‎src/bin/pgbench/pgbench.c`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1967,7 +1967,6 @@ doCustom(TState thread, CState st, StatsData *agg)`
`1967`	`1967`	`st->listen= false;`
`1968`	`1968`	`st->sleeping= false;`
`1969`	`1969`	`st->throttling= false;`
`1970`		`-st->is_throttled= false;`
`1971`	`1970`	`memset(st->prepared,0,sizeof(st->prepared));`
`1972`	`1971`	`}`
`1973`	`1972`
`@@ -4345,6 +4344,12 @@ threadRun(void *arg)`
`4345`	`4344`	`remains--;/* I've aborted */`
`4346`	`4345`	`}`
`4347`	`4346`	`}`
	`4347`	`+elseif (is_connect&&st->sleeping)`
	`4348`	`+{`
	`4349`	`+/* it is sleeping for throttling, maybe it is done, let us try */`
	`4350`	`+if (!doCustom(thread,st,&aggs))`
	`4351`	`+remains--;`
	`4352`	`+}`
`4348`	`4353`
`4349`	`4354`	`if (st->ecnt>prev_ecnt&&commands[st->state]->type==META_COMMAND)`
`4350`	`4355`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2ed391f

File tree

1 file changed

1 file changed

`‎src/bin/pgbench/pgbench.c`

0 commit comments