Commit2aae35d

committed

Mention the index name in 'could not create unique index' errors,

per suggestion from Rene Gollent.

1 parentb17b7fa commit2aae35dCopy full SHA for 2aae35d

File tree

-5

lines changed

-5

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@`
`91`	`91`	`* Portions Copyright (c) 1994, Regents of the University of California`
`92`	`92`	`*`
`93`	`93`	`* IDENTIFICATION`
`94`		`- * $PostgreSQL: pgsql/src/backend/utils/sort/tuplesort.c,v 1.78 2007/09/01 18:47:39 tgl Exp $`
	`94`	`+ * $PostgreSQL: pgsql/src/backend/utils/sort/tuplesort.c,v 1.79 2007/10/29 21:31:28 tgl Exp $`
`95`	`95`	`*`
`96`	`96`	`*-------------------------------------------------------------------------`
`97`	`97`	`*/`
`@@ -2720,7 +2720,8 @@ comparetup_index(const SortTuple a, const SortTuple b, Tuplesortstate *state)`
`2720`	`2720`	`if (state->enforceUnique&& !equal_hasnull&&tuple1!=tuple2)`
`2721`	`2721`	`ereport(ERROR,`
`2722`	`2722`	`(errcode(ERRCODE_UNIQUE_VIOLATION),`
`2723`		`-errmsg("could not create unique index"),`
	`2723`	`+errmsg("could not create unique index \"%s\"",`
	`2724`	`+RelationGetRelationName(state->indexRel)),`
`2724`	`2725`	`errdetail("Table contains duplicated values.")));`
`2725`	`2726`
`2726`	`2727`	`/*`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -417,7 +417,7 @@ insert into atacc1 (test) values (2);`
`417`	`417`	`-- add a unique constraint (fails)`
`418`	`418`	`alter table atacc1 add constraint atacc_test1 unique (test);`
`419`	`419`	`NOTICE: ALTER TABLE / ADD UNIQUE will create implicit index "atacc_test1" for table "atacc1"`
`420`		`-ERROR: could not create unique index`
	`420`	`+ERROR: could not create unique index "atacc_test1"`
`421`	`421`	`DETAIL: Table contains duplicated values.`
`422`	`422`	`insert into atacc1 (test) values (3);`
`423`	`423`	`drop table atacc1;`
`@@ -485,7 +485,7 @@ insert into atacc1 (test) values (2);`
`485`	`485`	`-- add a primary key (fails)`
`486`	`486`	`alter table atacc1 add constraint atacc_test1 primary key (test);`
`487`	`487`	`NOTICE: ALTER TABLE / ADD PRIMARY KEY will create implicit index "atacc_test1" for table "atacc1"`
`488`		`-ERROR: could not create unique index`
	`488`	`+ERROR: could not create unique index "atacc_test1"`
`489`	`489`	`DETAIL: Table contains duplicated values.`
`490`	`490`	`insert into atacc1 (test) values (3);`
`491`	`491`	`drop table atacc1;`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -389,7 +389,7 @@ INSERT INTO concur_heap VALUES ('b','x');`
`389`	`389`	`ERROR: duplicate key value violates unique constraint "concur_index2"`
`390`	`390`	`-- check if constraint is enforced properly at build time`
`391`	`391`	`CREATE UNIQUE INDEX CONCURRENTLY concur_index3 ON concur_heap(f2);`
`392`		`-ERROR: could not create unique index`
	`392`	`+ERROR: could not create unique index "concur_index3"`
`393`	`393`	`DETAIL: Table contains duplicated values.`
`394`	`394`	`-- test that expression indexes and partial indexes work concurrently`
`395`	`395`	`CREATE INDEX CONCURRENTLY concur_index4 on concur_heap(f2) WHERE f1='a';`

Comments

(0)