NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commit2a26639

committed

On further reflection, we'd better do the same in int.c.

We previously heard of the same problem in int24div(), so there's not agood reason to suppose the problem is confined to cases involving int8.

1 parent7233099 commit2a26639Copy full SHA for 2a26639

File tree

1 file changed

+21

-0

lines changed

src/backend/utils/adt
- int.c

1 file changed

+21

-0

lines changed

`‎src/backend/utils/adt/int.c‎`

Lines changed: 21 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -723,9 +723,13 @@ int4div(PG_FUNCTION_ARGS)`
`723`	`723`	`int32result;`
`724`	`724`
`725`	`725`	`if (arg2==0)`
	`726`	`+{`
`726`	`727`	`ereport(ERROR,`
`727`	`728`	`(errcode(ERRCODE_DIVISION_BY_ZERO),`
`728`	`729`	`errmsg("division by zero")));`
	`730`	`+/* ensure compiler realizes we mustn't reach the division (gcc bug) */`
	`731`	`+PG_RETURN_NULL();`
	`732`	`+}`
`729`	`733`
`730`	`734`	`#ifdefWIN32`
`731`	`735`
`@@ -864,9 +868,13 @@ int2div(PG_FUNCTION_ARGS)`
`864`	`868`	`int16result;`
`865`	`869`
`866`	`870`	`if (arg2==0)`
	`871`	`+{`
`867`	`872`	`ereport(ERROR,`
`868`	`873`	`(errcode(ERRCODE_DIVISION_BY_ZERO),`
`869`	`874`	`errmsg("division by zero")));`
	`875`	`+/* ensure compiler realizes we mustn't reach the division (gcc bug) */`
	`876`	`+PG_RETURN_NULL();`
	`877`	`+}`
`870`	`878`
`871`	`879`	`result=arg1 /arg2;`
`872`	`880`
`@@ -1048,9 +1056,13 @@ int42div(PG_FUNCTION_ARGS)`
`1048`	`1056`	`int32result;`
`1049`	`1057`
`1050`	`1058`	`if (arg2==0)`
	`1059`	`+{`
`1051`	`1060`	`ereport(ERROR,`
`1052`	`1061`	`(errcode(ERRCODE_DIVISION_BY_ZERO),`
`1053`	`1062`	`errmsg("division by zero")));`
	`1063`	`+/* ensure compiler realizes we mustn't reach the division (gcc bug) */`
	`1064`	`+PG_RETURN_NULL();`
	`1065`	`+}`
`1054`	`1066`
`1055`	`1067`	`result=arg1 /arg2;`
`1056`	`1068`
`@@ -1074,9 +1086,13 @@ int4mod(PG_FUNCTION_ARGS)`
`1074`	`1086`	`int32arg2=PG_GETARG_INT32(1);`
`1075`	`1087`
`1076`	`1088`	`if (arg2==0)`
	`1089`	`+{`
`1077`	`1090`	`ereport(ERROR,`
`1078`	`1091`	`(errcode(ERRCODE_DIVISION_BY_ZERO),`
`1079`	`1092`	`errmsg("division by zero")));`
	`1093`	`+/* ensure compiler realizes we mustn't reach the division (gcc bug) */`
	`1094`	`+PG_RETURN_NULL();`
	`1095`	`+}`
`1080`	`1096`
`1081`	`1097`	`/* SELECT ((-2147483648)::int4) % (-1); causes a floating point exception */`
`1082`	`1098`	`if (arg1==INT_MIN&&arg2==-1)`
`@@ -1094,9 +1110,14 @@ int2mod(PG_FUNCTION_ARGS)`
`1094`	`1110`	`int16arg2=PG_GETARG_INT16(1);`
`1095`	`1111`
`1096`	`1112`	`if (arg2==0)`
	`1113`	`+{`
`1097`	`1114`	`ereport(ERROR,`
`1098`	`1115`	`(errcode(ERRCODE_DIVISION_BY_ZERO),`
`1099`	`1116`	`errmsg("division by zero")));`
	`1117`	`+/* ensure compiler realizes we mustn't reach the division (gcc bug) */`
	`1118`	`+PG_RETURN_NULL();`
	`1119`	`+}`
	`1120`	`+`
`1100`	`1121`	`/* No overflow is possible */`
`1101`	`1122`
`1102`	`1123`	`PG_RETURN_INT16(arg1 %arg2);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2a26639

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/int.c‎`

0 commit comments