Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit27f145a

Browse files
committed
Further dtrace adjustments for the backend-IDs-in-relpath patch.
Update the documentation, and back out a few ill-considered changeswhose folly I failed to realize for failure to read the documentation.
1 parent105d4c5 commit27f145a

File tree

3 files changed

+29
-21
lines changed

3 files changed

+29
-21
lines changed

‎doc/src/sgml/monitoring.sgml‎

Lines changed: 23 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!-- $PostgreSQL: pgsql/doc/src/sgml/monitoring.sgml,v 1.82 2010/08/08 16:27:03 tgl Exp $ -->
1+
<!-- $PostgreSQL: pgsql/doc/src/sgml/monitoring.sgml,v 1.83 2010/08/14 02:22:10 rhaas Exp $ -->
22

33
<chapter id="monitoring">
44
<title>Monitoring Database Activity</title>
@@ -1436,26 +1436,28 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS procpid,
14361436
</row>
14371437
<row>
14381438
<entry>buffer-read-start</entry>
1439-
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid,bool, bool)</entry>
1439+
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid,int, bool)</entry>
14401440
<entry>Probe that fires when a buffer read is started.
14411441
arg0 and arg1 contain the fork and block numbers of the page (but
14421442
arg1 will be -1 if this is a relation extension request).
14431443
arg2, arg3, and arg4 contain the tablespace, database, and relation OIDs
14441444
identifying the relation.
1445-
arg5 is true for a local buffer, false for a shared buffer.
1445+
arg5 is the ID of the backend which created the temporary relation for a
1446+
local buffer, or InvalidBackendId (-1) for a shared buffer.
14461447
arg6 is true for a relation extension request, false for normal
14471448
read.</entry>
14481449
</row>
14491450
<row>
14501451
<entry>buffer-read-done</entry>
1451-
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid,bool, bool, bool)</entry>
1452+
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid,int, bool, bool)</entry>
14521453
<entry>Probe that fires when a buffer read is complete.
14531454
arg0 and arg1 contain the fork and block numbers of the page (if this
14541455
is a relation extension request, arg1 now contains the block number
14551456
of the newly added block).
14561457
arg2, arg3, and arg4 contain the tablespace, database, and relation OIDs
14571458
identifying the relation.
1458-
arg5 is true for a local buffer, false for a shared buffer.
1459+
arg5 is the ID of the backend which created the temporary relation for a
1460+
local buffer, or InvalidBackendId (-1) for a shared buffer.
14591461
arg6 is true for a relation extension request, false for normal
14601462
read.
14611463
arg7 is true if the buffer was found in the pool, false if not.</entry>
@@ -1521,38 +1523,46 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS procpid,
15211523
</row>
15221524
<row>
15231525
<entry>smgr-md-read-start</entry>
1524-
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid)</entry>
1526+
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid, int)</entry>
15251527
<entry>Probe that fires when beginning to read a block from a relation.
15261528
arg0 and arg1 contain the fork and block numbers of the page.
15271529
arg2, arg3, and arg4 contain the tablespace, database, and relation OIDs
1528-
identifying the relation.</entry>
1530+
identifying the relation.
1531+
arg5 is the ID of the backend which created the temporary relation for a
1532+
local buffer, or InvalidBackendId (-1) for a shared buffer.</entry>
15291533
</row>
15301534
<row>
15311535
<entry>smgr-md-read-done</entry>
1532-
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid, int, int)</entry>
1536+
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid, int, int, int)</entry>
15331537
<entry>Probe that fires when a block read is complete.
15341538
arg0 and arg1 contain the fork and block numbers of the page.
15351539
arg2, arg3, and arg4 contain the tablespace, database, and relation OIDs
15361540
identifying the relation.
1537-
arg5 is the number of bytes actually read, while arg6 is the number
1541+
arg5 is the ID of the backend which created the temporary relation for a
1542+
local buffer, or InvalidBackendId (-1) for a shared buffer.
1543+
arg6 is the number of bytes actually read, while arg7 is the number
15381544
requested (if these are different it indicates trouble).</entry>
15391545
</row>
15401546
<row>
15411547
<entry>smgr-md-write-start</entry>
1542-
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid)</entry>
1548+
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid, int)</entry>
15431549
<entry>Probe that fires when beginning to write a block to a relation.
15441550
arg0 and arg1 contain the fork and block numbers of the page.
15451551
arg2, arg3, and arg4 contain the tablespace, database, and relation OIDs
1546-
identifying the relation.</entry>
1552+
identifying the relation.
1553+
arg5 is the ID of the backend which created the temporary relation for a
1554+
local buffer, or InvalidBackendId (-1) for a shared buffer.</entry>
15471555
</row>
15481556
<row>
15491557
<entry>smgr-md-write-done</entry>
1550-
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid, int, int)</entry>
1558+
<entry>(ForkNumber, BlockNumber, Oid, Oid, Oid, int, int, int)</entry>
15511559
<entry>Probe that fires when a block write is complete.
15521560
arg0 and arg1 contain the fork and block numbers of the page.
15531561
arg2, arg3, and arg4 contain the tablespace, database, and relation OIDs
15541562
identifying the relation.
1555-
arg5 is the number of bytes actually written, while arg6 is the number
1563+
arg5 is the ID of the backend which created the temporary relation for a
1564+
local buffer, or InvalidBackendId (-1) for a shared buffer.
1565+
arg6 is the number of bytes actually written, while arg7 is the number
15561566
requested (if these are different it indicates trouble).</entry>
15571567
</row>
15581568
<row>

‎src/backend/storage/buffer/bufmgr.c‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.258 2010/08/1322:54:17 rhaas Exp $
11+
* $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.259 2010/08/14 02:22:10 rhaas Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -1852,8 +1852,7 @@ FlushBuffer(volatile BufferDesc *buf, SMgrRelation reln)
18521852
buf->tag.blockNum,
18531853
reln->smgr_rnode.node.spcNode,
18541854
reln->smgr_rnode.node.dbNode,
1855-
reln->smgr_rnode.node.relNode,
1856-
reln->smgr_rnode.backend);
1855+
reln->smgr_rnode.node.relNode);
18571856

18581857
/*
18591858
* Force XLOG flush up to buffer's LSN. This implements the basic WAL
@@ -1892,8 +1891,7 @@ FlushBuffer(volatile BufferDesc *buf, SMgrRelation reln)
18921891
buf->tag.blockNum,
18931892
reln->smgr_rnode.node.spcNode,
18941893
reln->smgr_rnode.node.dbNode,
1895-
reln->smgr_rnode.node.relNode,
1896-
reln->smgr_rnode.backend);
1894+
reln->smgr_rnode.node.relNode);
18971895

18981896
/* Pop the error context stack */
18991897
error_context_stack=errcontext.previous;

‎src/backend/utils/probes.d‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
*
44
*Copyright (c) 2006-2010, PostgreSQL Global Development Group
55
*
6-
*$PostgreSQL: pgsql/src/backend/utils/probes.d,v 1.14 2010/08/1322:54:17 rhaas Exp $
6+
*$PostgreSQL: pgsql/src/backend/utils/probes.d,v 1.15 2010/08/14 02:22:10 rhaas Exp $
77
* ----------
88
*/
99

@@ -56,8 +56,8 @@ provider postgresql {
5656

5757
probebuffer__read__start(ForkNumber,BlockNumber,Oid,Oid,Oid,int,bool);
5858
probebuffer__read__done(ForkNumber,BlockNumber,Oid,Oid,Oid,int,bool,bool);
59-
probebuffer__flush__start(ForkNumber,BlockNumber,Oid,Oid,Oid,int);
60-
probebuffer__flush__done(ForkNumber,BlockNumber,Oid,Oid,Oid,int);
59+
probebuffer__flush__start(ForkNumber,BlockNumber,Oid,Oid,Oid);
60+
probebuffer__flush__done(ForkNumber,BlockNumber,Oid,Oid,Oid);
6161

6262
probebuffer__checkpoint__start(int);
6363
probebuffer__checkpoint__sync__start();

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp