- Notifications
You must be signed in to change notification settings - Fork28
Commit26a76cb
committed
Restrict pgbench's zipfian parameter to ensure good performance.
Remove the code that supported zipfian distribution parameters lessthan 1.0, as it had undocumented performance hazards, and it's notclear that the case is useful enough to justify either fixing ordocumenting those hazards.Also, since the code path for parameter > 1.0 could perform badlyfor values very close to 1.0, establish a minimum allowed valueof 1.001. This solution seems superior to the previous vaguedocumentation warning about small values not performing well.Fabien Coelho, per a gripe from Tomas VondraDiscussion:https://postgr.es/m/b5e172e9-ad22-48a3-86a3-589afa20e8f7@2ndquadrant.com1 parent4fd05bb commit26a76cb
File tree
3 files changed
+32
-193
lines changed- doc/src/sgml/ref
- src/bin/pgbench
- t
3 files changed
+32
-193
lines changedLines changed: 11 additions & 16 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1543 | 1543 |
| |
1544 | 1544 |
| |
1545 | 1545 |
| |
1546 |
| - | |
1547 |
| - | |
| 1546 | + | |
| 1547 | + | |
1548 | 1548 |
| |
1549 | 1549 |
| |
1550 | 1550 |
| |
1551 | 1551 |
| |
1552 |
| - | |
1553 |
| - | |
1554 |
| - | |
1555 |
| - | |
1556 |
| - | |
1557 |
| - | |
1558 |
| - | |
1559 |
| - | |
1560 |
| - | |
1561 |
| - | |
1562 |
| - | |
1563 |
| - | |
| 1552 | + | |
| 1553 | + | |
1564 | 1554 |
| |
1565 | 1555 |
| |
1566 | 1556 |
| |
1567 |
| - | |
1568 |
| - | |
1569 | 1557 |
| |
1570 | 1558 |
| |
1571 | 1559 |
| |
| |||
1576 | 1564 |
| |
1577 | 1565 |
| |
1578 | 1566 |
| |
| 1567 | + | |
| 1568 | + | |
| 1569 | + | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
1579 | 1574 |
| |
1580 | 1575 |
| |
1581 | 1576 |
| |
|
Lines changed: 19 additions & 148 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
135 | 135 |
| |
136 | 136 |
| |
137 | 137 |
| |
138 |
| - | |
139 |
| - | |
140 | 138 |
| |
141 |
| - | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
142 | 142 |
| |
143 | 143 |
| |
144 | 144 |
| |
| |||
410 | 410 |
| |
411 | 411 |
| |
412 | 412 |
| |
413 |
| - | |
414 |
| - | |
415 |
| - | |
416 |
| - | |
417 |
| - | |
418 |
| - | |
419 |
| - | |
420 |
| - | |
421 |
| - | |
422 |
| - | |
423 |
| - | |
424 |
| - | |
425 |
| - | |
426 |
| - | |
427 |
| - | |
428 |
| - | |
429 |
| - | |
430 |
| - | |
431 |
| - | |
432 |
| - | |
433 |
| - | |
434 |
| - | |
435 |
| - | |
436 |
| - | |
437 |
| - | |
438 |
| - | |
439 |
| - | |
440 |
| - | |
441 |
| - | |
442 | 413 |
| |
443 | 414 |
| |
444 | 415 |
| |
| |||
460 | 431 |
| |
461 | 432 |
| |
462 | 433 |
| |
463 |
| - | |
464 |
| - | |
465 | 434 |
| |
466 | 435 |
| |
467 | 436 |
| |
| |||
975 | 944 |
| |
976 | 945 |
| |
977 | 946 |
| |
978 |
| - | |
979 |
| - | |
980 |
| - | |
981 |
| - | |
982 |
| - | |
983 |
| - | |
984 |
| - | |
985 |
| - | |
986 |
| - | |
987 |
| - | |
988 |
| - | |
989 |
| - | |
990 |
| - | |
991 |
| - | |
992 |
| - | |
993 |
| - | |
994 |
| - | |
995 |
| - | |
996 |
| - | |
997 |
| - | |
998 |
| - | |
999 |
| - | |
1000 |
| - | |
1001 |
| - | |
1002 |
| - | |
1003 |
| - | |
1004 |
| - | |
1005 |
| - | |
1006 |
| - | |
1007 |
| - | |
1008 |
| - | |
1009 |
| - | |
1010 |
| - | |
1011 |
| - | |
1012 |
| - | |
1013 |
| - | |
1014 |
| - | |
1015 |
| - | |
1016 |
| - | |
1017 |
| - | |
1018 |
| - | |
1019 |
| - | |
1020 |
| - | |
1021 |
| - | |
1022 |
| - | |
1023 |
| - | |
1024 |
| - | |
1025 |
| - | |
1026 |
| - | |
1027 |
| - | |
1028 |
| - | |
1029 |
| - | |
1030 |
| - | |
1031 |
| - | |
1032 |
| - | |
1033 |
| - | |
1034 |
| - | |
1035 |
| - | |
1036 |
| - | |
1037 |
| - | |
1038 |
| - | |
1039 |
| - | |
1040 |
| - | |
1041 |
| - | |
1042 |
| - | |
1043 |
| - | |
1044 |
| - | |
1045 | 947 |
| |
1046 | 948 |
| |
1047 | 949 |
| |
1048 | 950 |
| |
| 951 | + | |
| 952 | + | |
1049 | 953 |
| |
1050 | 954 |
| |
1051 | 955 |
| |
| |||
1056 | 960 |
| |
1057 | 961 |
| |
1058 | 962 |
| |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
1059 | 967 |
| |
1060 | 968 |
| |
1061 | 969 |
| |
| |||
1072 | 980 |
| |
1073 | 981 |
| |
1074 | 982 |
| |
1075 |
| - | |
1076 |
| - | |
1077 |
| - | |
1078 |
| - | |
1079 |
| - | |
1080 |
| - | |
1081 |
| - | |
1082 |
| - | |
1083 |
| - | |
1084 |
| - | |
1085 |
| - | |
1086 |
| - | |
1087 |
| - | |
1088 |
| - | |
1089 |
| - | |
1090 |
| - | |
1091 |
| - | |
1092 |
| - | |
1093 |
| - | |
1094 |
| - | |
1095 | 983 |
| |
1096 | 984 |
| |
1097 |
| - | |
1098 |
| - | |
| 985 | + | |
1099 | 986 |
| |
1100 | 987 |
| |
1101 | 988 |
| |
1102 | 989 |
| |
1103 |
| - | |
| 990 | + | |
1104 | 991 |
| |
1105 |
| - | |
1106 |
| - | |
1107 |
| - | |
| 992 | + | |
1108 | 993 |
| |
1109 | 994 |
| |
1110 | 995 |
| |
| |||
2426 | 2311 |
| |
2427 | 2312 |
| |
2428 | 2313 |
| |
2429 |
| - | |
| 2314 | + | |
2430 | 2315 |
| |
2431 | 2316 |
| |
2432 |
| - | |
2433 |
| - | |
| 2317 | + | |
| 2318 | + | |
| 2319 | + | |
2434 | 2320 |
| |
2435 | 2321 |
| |
| 2322 | + | |
2436 | 2323 |
| |
2437 |
| - | |
2438 |
| - | |
2439 |
| - | |
| 2324 | + | |
2440 | 2325 |
| |
2441 | 2326 |
| |
2442 | 2327 |
| |
2443 | 2328 |
| |
2444 | 2329 |
| |
2445 | 2330 |
| |
2446 | 2331 |
| |
2447 |
| - | |
| 2332 | + | |
2448 | 2333 |
| |
2449 | 2334 |
| |
2450 | 2335 |
| |
| |||
4996 | 4881 |
| |
4997 | 4882 |
| |
4998 | 4883 |
| |
4999 |
| - | |
5000 |
| - | |
5001 | 4884 |
| |
5002 | 4885 |
| |
5003 | 4886 |
| |
| |||
5025 | 4908 |
| |
5026 | 4909 |
| |
5027 | 4910 |
| |
5028 |
| - | |
5029 |
| - | |
5030 |
| - | |
5031 |
| - | |
5032 |
| - | |
5033 |
| - | |
5034 |
| - | |
5035 |
| - | |
5036 |
| - | |
5037 | 4911 |
| |
5038 | 4912 |
| |
5039 | 4913 |
| |
| |||
5916 | 5790 |
| |
5917 | 5791 |
| |
5918 | 5792 |
| |
5919 |
| - | |
5920 |
| - | |
5921 |
| - | |
5922 | 5793 |
| |
5923 | 5794 |
| |
5924 | 5795 |
| |
|
Lines changed: 2 additions & 29 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
666 | 666 |
| |
667 | 667 |
| |
668 | 668 |
| |
669 |
| - | |
| 669 | + | |
670 | 670 |
| |
671 | 671 |
| |
672 | 672 |
| |
673 | 673 |
| |
674 | 674 |
| |
675 |
| - | |
| 675 | + | |
676 | 676 |
| |
677 | 677 |
| |
678 | 678 |
| |
| |||
802 | 802 |
| |
803 | 803 |
| |
804 | 804 |
| |
805 |
| - | |
806 |
| - | |
807 |
| - | |
808 |
| - | |
809 |
| - | |
810 |
| - | |
811 |
| - | |
812 |
| - | |
813 |
| - | |
814 |
| - | |
815 |
| - | |
816 |
| - | |
817 |
| - | |
818 |
| - | |
819 |
| - | |
820 |
| - | |
821 |
| - | |
822 |
| - | |
823 |
| - | |
824 |
| - | |
825 |
| - | |
826 |
| - | |
827 |
| - | |
828 |
| - | |
829 |
| - | |
830 |
| - | |
831 |
| - | |
832 | 805 |
| |
833 | 806 |
| |
834 | 807 |
| |
|
0 commit comments
Comments
(0)