NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit24a814f

committed

plpgsql's exec_simple_cast_value() mistakenly supposed that it could bypass

casting effort whenever the input value was NULL. However this preventsapplication of not-null domain constraints in the cases that use thisfunction, as illustrated in bug #4741. Since this function isn't meantfor use in performance-critical paths anyway, this certainly seems likeanother case of "premature optimization is the root of all evil".Back-patch as far as 8.2; older versions made no effort to enforcedomain constraints here anyway.

1 parentbfd17f9 commit24a814fCopy full SHA for 24a814f

File tree

1 file changed

+14

-17

lines changed

src/pl/plpgsql/src
- pl_exec.c

1 file changed

+14

-17

lines changed

`‎src/pl/plpgsql/src/pl_exec.c‎`

Lines changed: 14 additions & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.236 2009/03/26 22:26:08 petere Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.237 2009/04/02 01:16:11 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -4754,26 +4754,23 @@ exec_simple_cast_value(Datum value, Oid valtype,`
`4754`	`4754`	`Oidreqtype,int32reqtypmod,`
`4755`	`4755`	`boolisnull)`
`4756`	`4756`	`{`
`4757`		`-if (!isnull)`
	`4757`	`+if (valtype!=reqtype\|\|reqtypmod!=-1)`
`4758`	`4758`	`{`
`4759`		`-if (valtype!=reqtype\|\|reqtypmod!=-1)`
`4760`		`-{`
`4761`		`-Oidtypinput;`
`4762`		`-Oidtypioparam;`
`4763`		`-FmgrInfofinfo_input;`
	`4759`	`+Oidtypinput;`
	`4760`	`+Oidtypioparam;`
	`4761`	`+FmgrInfofinfo_input;`
`4764`	`4762`
`4765`		`-getTypeInputInfo(reqtype,&typinput,&typioparam);`
	`4763`	`+getTypeInputInfo(reqtype,&typinput,&typioparam);`
`4766`	`4764`
`4767`		`-fmgr_info(typinput,&finfo_input);`
	`4765`	`+fmgr_info(typinput,&finfo_input);`
`4768`	`4766`
`4769`		`-value=exec_cast_value(value,`
`4770`		`-valtype,`
`4771`		`-reqtype,`
`4772`		`-&finfo_input,`
`4773`		`-typioparam,`
`4774`		`-reqtypmod,`
`4775`		`-isnull);`
`4776`		`-}`
	`4767`	`+value=exec_cast_value(value,`
	`4768`	`+valtype,`
	`4769`	`+reqtype,`
	`4770`	`+&finfo_input,`
	`4771`	`+typioparam,`
	`4772`	`+reqtypmod,`
	`4773`	`+isnull);`
`4777`	`4774`	`}`
`4778`	`4775`
`4779`	`4776`	`returnvalue;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit24a814f

File tree

1 file changed

1 file changed

`‎src/pl/plpgsql/src/pl_exec.c‎`

0 commit comments