NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit234e4cf

committed

During parallel pg_dump, free commands from master

The command strings read by the child processes during parallelpg_dump, after being read and handled, were not being free'd.This patch corrects this relatively minor memory leak.Leak found by the Coverity scanner.Back patch to 9.3 where parallel pg_dump was introduced.

1 parent070518d commit234e4cfCopy full SHA for 234e4cf

File tree

1 file changed

-0

lines changed

src/bin/pg_dump
- parallel.c

1 file changed

-0

lines changed

`‎src/bin/pg_dump/parallel.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -922,6 +922,9 @@ WaitForCommands(ArchiveHandle *AH, int pipefd[2])`
`922`	`922`	`exit_horribly(modulename,`
`923`	`923`	`"unrecognized command on communication channel: %s\n",`
`924`	`924`	`command);`
	`925`	`+`
	`926`	`+/* command was pg_malloc'd and we are responsible for free()ing it. */`
	`927`	`+free(command);`
`925`	`928`	`}`
`926`	`929`	`}`
`927`	`930`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit234e4cf

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/parallel.c`

0 commit comments