Commit2284abc

committed

add more comments for RowMarks fixes etc

1 parent8b3b05c commit2284abcCopy full SHA for 2284abc

File tree

+21

-4

lines changed

+21

-4

lines changed

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,13 @@`
`2`	`2`	`*`
`3`	`3`	`* relation_tags.h`
`4`	`4`	`*Attach custom (Key, Value) pairs to an arbitrary RangeTblEntry`
`5`		`- *NOTE: implementations for vanilla and PostgresPro differ`
	`5`	`+ *`
	`6`	`+ *NOTE: implementations for vanilla and PostgresPro differ,`
	`7`	`+ *which means that subquery pull-up might break the bond`
	`8`	`+ *between a RangeTblEntry and the corresponding KVPs.`
	`9`	`+ *`
	`10`	`+ *This subsystem was meant to replace the broken 'inh' flag`
	`11`	`+ *(see get_rel_parenthood_status() for more details).`
`6`	`12`	`*`
`7`	`13`	`* Copyright (c) 2017, Postgres Professional`
`8`	`14`	`*`

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,16 @@ void append_tle_for_rowmark(PlannerInfo root, PlanRowMark rc);`
`29`	`29`
`30`	`30`	`#else`
`31`	`31`
`32`		`-#defineLEGACY_ROWMARKS_95/* NOTE: can't fix 9.5, see PlannerInfo->processed_tlist */`
	`32`	`+/*`
	`33`	`+ * Starting from 9.6, it's possible to append junk`
	`34`	`+ * tableoid columns using the PlannerInfo->processed_tlist.`
	`35`	`+ * This is absolutely crucial for UPDATE and DELETE queries,`
	`36`	`+ * so we had to add some special fixes for 9.5:`
	`37`	`+ *`
	`38`	`+ *1) provide legacy code for RowMarks (tableoids);`
	`39`	`+ *2) disable dangerous UPDATE & DELETE optimizations.`
	`40`	`+ */`
	`41`	`+#defineLEGACY_ROWMARKS_95`
`33`	`42`
`34`	`43`	`#defineappend_tle_for_rowmark(root,rc)( (void) true )`
`35`	`44`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -44,14 +44,16 @@`
`44`	`44`
`45`	`45`	`typedefstruct`
`46`	`46`	`{`
`47`		`-/bool has_parent_CMD_TYPE_query; /`
	`47`	`+/Do we have a parent CmdType query? /`
`48`	`48`	`boolTRANSFORM_CONTEXT_FIELD(SELECT),`
`49`	`49`	`TRANSFORM_CONTEXT_FIELD(INSERT),`
`50`	`50`	`TRANSFORM_CONTEXT_FIELD(UPDATE),`
`51`	`51`	`TRANSFORM_CONTEXT_FIELD(DELETE);`
`52`	`52`
`53`		`-/params for handle_modification_query() /`
	`53`	`+/Parameters for handle_modification_query() /`
`54`	`54`	`ParamListInfoquery_params;`
	`55`	`+`
	`56`	`+/* SubLink that might contain an examined query */`
`55`	`57`	`SubLink*parent_sublink;`
`56`	`58`	`}transform_query_cxt;`
`57`	`59`

Comments

(0)