Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit203a909

Browse files
committed
Update pg_upgrade test for reg* to include regrole and regnamespace.
When the regrole (0c90f67) and regnamespace (cb9fa80) types wereadded in 9.5, pg_upgrade's check for reg* types wasn't updated. Whileregrole currently is safe, regnamespace is not.It seems unlikely that anybody uses regnamespace inside catalog tablesacross a pg_upgrade, but the tests should be correct nevertheless.While at it, reorder the types checked in the query to bealphabetical. Otherwise it's annoying to compare existing and testedfor types.Author: Andres FreundDiscussion:https://postgr.es/m/037e152a-cb25-3bcb-4f35-bdc9988f8204@2ndQuadrant.comBackpatch: 9.5-, as regrole/regnamespace
1 parentad6dfc6 commit203a909

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

‎src/bin/pg_upgrade/check.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -919,14 +919,17 @@ check_for_reg_data_type_usage(ClusterInfo *cluster)
919919
"WHEREc.oid = a.attrelid AND "
920920
"NOT a.attisdropped AND "
921921
"a.atttypid IN ( "
922-
"'pg_catalog.regproc'::pg_catalog.regtype, "
923-
"'pg_catalog.regprocedure'::pg_catalog.regtype, "
922+
/* regclass.oid is preserved, so 'regclass' is OK */
923+
"'pg_catalog.regconfig'::pg_catalog.regtype, "
924+
"'pg_catalog.regdictionary'::pg_catalog.regtype, "
925+
"'pg_catalog.regnamespace'::pg_catalog.regtype, "
924926
"'pg_catalog.regoper'::pg_catalog.regtype, "
925927
"'pg_catalog.regoperator'::pg_catalog.regtype, "
926-
/* regclass.oid is preserved, so 'regclass' is OK */
928+
"'pg_catalog.regproc'::pg_catalog.regtype, "
929+
"'pg_catalog.regprocedure'::pg_catalog.regtype "
930+
/* regrole.oid is preserved, so 'regrole' is OK */
927931
/* regtype.oid is preserved, so 'regtype' is OK */
928-
"'pg_catalog.regconfig'::pg_catalog.regtype, "
929-
"'pg_catalog.regdictionary'::pg_catalog.regtype) AND "
932+
") AND "
930933
"c.relnamespace = n.oid AND "
931934
"n.nspname NOT IN ('pg_catalog', 'information_schema')");
932935

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp